-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
database: add filter to insert logic #623
Conversation
Turns out clients can be generating more fields/values than the database/cherrypy server know about owing to separate MTT based projects contributing code. Fixes open-mpi#614 Signed-off-by: Howard Pritchard <howardp@lanl.gov>
Howard's a happy camper with this patch:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! And you tested it
I say merge :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the only thing I would add to this is if we reject a field because it is not in the table, then we should probably issue a warning - in the log and/or back to the user. But that's not a show stopper.
Thanks!
Signed-off-by: Howard Pritchard <howardp@lanl.gov>
@jjhursey good idea. I added the debug output back in. Here's what the AWS mtt database doesn't know about:
|
database: add filter to insert logic
Turns out clients can be generating more
fields/values than the database/cherrypy server
know about owing to separate MTT based projects
contributing code.
Fixes #614
Signed-off-by: Howard Pritchard howardp@lanl.gov