Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could you support recall, F-score and Precision #420

Closed
zhongqiu1245 opened this issue Mar 14, 2021 · 2 comments
Closed

Could you support recall, F-score and Precision #420

zhongqiu1245 opened this issue Mar 14, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@zhongqiu1245
Copy link

Motivation
They are very useful for mmsegmentation.

Related resources
https://github.com/qubvel/segmentation_models.pytorch/blob/master/segmentation_models_pytorch/utils/metrics.py

Thank you!

@xvjiarui xvjiarui added the enhancement New feature or request label Mar 20, 2021
@sshuair
Copy link
Contributor

sshuair commented Apr 20, 2021

@xvjiarui I am trying to add new feature support Recall, Precision and F-score. The core code has been implemented.

But there is a problem that needs to be discussed:

currently, the mIoU and mDice only return two metrics, IoU Acc or Dice Acc.

For f-score, usually these are three metrics Recall, Precision and F-score appear at the same time. But the mmseg/datasets/custom.py evaluate method only handle two metrics.

Should we consider refactor the evaluate and the metrics.py method?

Here is the proposal:

  1. change the metrics.py/mean_dice metrics.py/mean_iou and metrics.py/mean_fscore function return value from tuple to dict.
  2. the returned dict contain the metrics name to generate the summary data and print log.

@MengzhangLI
Copy link
Contributor

It is an excellent suggestion and great PR.

I will close it but feel free to re-open it anytime you want.

Best,

aravind-h-v pushed a commit to aravind-h-v/mmsegmentation that referenced this issue Mar 27, 2023
wjkim81 pushed a commit to wjkim81/mmsegmentation that referenced this issue Dec 3, 2023
* add bib for datasets

* update configs
sibozhang pushed a commit to sibozhang/mmsegmentation that referenced this issue Mar 22, 2024
* Add a faq about onnx.

Minor.

* minor format.

* Add changelog.

fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants