-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]fix: split autoslim different checkpoint has equal model size #193
Conversation
Codecov Report
@@ Coverage Diff @@
## master #193 +/- ##
==========================================
+ Coverage 63.95% 65.88% +1.93%
==========================================
Files 93 93
Lines 3462 3462
Branches 640 640
==========================================
+ Hits 2214 2281 +67
+ Misses 1136 1077 -59
+ Partials 112 104 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Hi @Hiwyl, thank you very much for your pr. OpenMMLab use pre-commit hook to avoid issues of code style. You can use the following two commands to get started with the pre-commit hook quickly.
The installation of pre-commit may be affected by the network. |
Has been updated. |
@@ -844,8 +853,7 @@ def concat_backward_parser(self, grad_fn, module2name, var2module, | |||
# However, a shared module will be visited more than once during | |||
# forward, so it is still need to be traced even if it has been | |||
# visited. | |||
if (name in visited and visited[name] | |||
and name not in self.shared_module): | |||
if name in visited and visited[name] and name not in self.shared_module: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is too long to pass the lint check.
More details can be found at https://github.com/open-mmlab/mmrazor/runs/7088305507?check_suite_focus=true
LGTM if passed CI |
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
autoslim get subnet by split_checkpoints is wrone.
Modification
BC-breaking (Optional)
Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here and update the documentation.
Checklist
Before PR:
After PR: