Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Use MMCV's EvalHook in MMClassification #182

Merged
merged 2 commits into from
Mar 25, 2021

Conversation

LXXXXR
Copy link
Contributor

@LXXXXR LXXXXR commented Mar 23, 2021

Hi,
This pull request uses EvalHook from mmcv(open-mmlab/mmcv#739) to replace ones in mmcls. Both are supported for mmcls v0.10.0, but the after that, EvalHook and DistEvalHook will be removed.

Pls kindly take a look. Thx.

@codecov
Copy link

codecov bot commented Mar 23, 2021

Codecov Report

Merging #182 (a9356ca) into master (49ece04) will increase coverage by 0.05%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #182      +/-   ##
==========================================
+ Coverage   71.88%   71.94%   +0.05%     
==========================================
  Files          82       82              
  Lines        3802     3810       +8     
  Branches      687      687              
==========================================
+ Hits         2733     2741       +8     
  Misses        987      987              
  Partials       82       82              
Flag Coverage Δ
unittests 71.94% <90.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcls/apis/train.py 29.03% <85.71%> (+6.22%) ⬆️
mmcls/core/evaluation/eval_hooks.py 89.65% <100.00%> (+0.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49ece04...a9356ca. Read the comment docs.

Copy link
Contributor

@ycxioooong ycxioooong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ycxioooong ycxioooong merged commit b507fc2 into open-mmlab:master Mar 25, 2021
mzr1996 pushed a commit to mzr1996/mmpretrain that referenced this pull request Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants