Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Github Badge for Workflow #2020

Merged
merged 14 commits into from
May 18, 2023
Merged

Conversation

huayuan4396
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@huayuan4396
Copy link
Collaborator Author

huayuan4396 commented Apr 23, 2023

May have to enable the Read and Write Permissions in the repo action setting.

@codecov
Copy link

codecov bot commented Apr 23, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (26b66ef) 49.70% compared to head (95094d8) 49.70%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2020   +/-   ##
=======================================
  Coverage   49.70%   49.70%           
=======================================
  Files         339      339           
  Lines       12976    12976           
  Branches     1900     1900           
=======================================
  Hits         6450     6450           
  Misses       6077     6077           
  Partials      449      449           
Flag Coverage Δ
unittests 49.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@huayuan4396 huayuan4396 force-pushed the dev_badge branch 2 times, most recently from 7119831 to f7cf9d8 Compare April 27, 2023 04:52
@lvhan028 lvhan028 requested a review from RunningLeon April 28, 2023 06:08
@RunningLeon RunningLeon requested a review from lvhan028 April 28, 2023 06:08
@RunningLeon RunningLeon added the documentation Improvements or additions to documentation label Apr 28, 2023
@RunningLeon
Copy link
Collaborator

@huayuan4396 it seems the RubbaBoy/BYOB@v1.2.1 only works on linux

@huayuan4396
Copy link
Collaborator Author

@huayuan4396 it seems the RubbaBoy/BYOB@v1.2.1 only works on linux

May have to do this by using a job instead of step for windows.

@RunningLeon
Copy link
Collaborator

@huayuan4396 Could sync with latest main branch to fix all ci errors.

Copy link
Collaborator

@RunningLeon RunningLeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RunningLeon RunningLeon requested review from AllentDan and lvhan028 and removed request for lvhan028 May 16, 2023 07:20
Copy link
Member

@AllentDan AllentDan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RunningLeon RunningLeon merged commit 8e658cd into open-mmlab:main May 18, 2023
@huayuan4396 huayuan4396 deleted the dev_badge branch May 19, 2023 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants