Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix dataloader for ncnn quantization #2018

Merged
merged 2 commits into from
May 8, 2023

Conversation

irexyc
Copy link
Collaborator

@irexyc irexyc commented Apr 23, 2023

Motivation

fix #1991

Modification

dataloader for ppq

@irexyc irexyc mentioned this pull request Apr 23, 2023
3 tasks
@codecov
Copy link

codecov bot commented Apr 23, 2023

Codecov Report

Patch coverage: 37.50% and project coverage change: +0.01 🎉

Comparison is base (2c7e91b) 49.44% compared to head (40f3c25) 49.45%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2018      +/-   ##
==========================================
+ Coverage   49.44%   49.45%   +0.01%     
==========================================
  Files         338      338              
  Lines       12920    12920              
  Branches     1897     1898       +1     
==========================================
+ Hits         6388     6390       +2     
+ Misses       6088     6085       -3     
- Partials      444      445       +1     
Flag Coverage Δ
unittests 49.45% <37.50%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdeploy/codebase/mmpose/deploy/pose_detection.py 72.57% <37.50%> (+1.14%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@RunningLeon RunningLeon requested a review from tpoisonooo May 6, 2023 06:17
@RunningLeon RunningLeon added the bug Something isn't working label May 6, 2023
@RunningLeon RunningLeon requested a review from AllentDan May 6, 2023 06:19
Copy link
Collaborator

@RunningLeon RunningLeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RunningLeon
Copy link
Collaborator

@tpoisonooo @AllentDan any comment on this PR?

tools/onnx2ncnn_quant_table.py Show resolved Hide resolved
Copy link
Member

@AllentDan AllentDan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after resolving comments.

@RunningLeon RunningLeon merged commit 49103cb into open-mmlab:main May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] LiteHRNet Quantization Error
4 participants