Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mmcls -> mmpretrain #2003

Merged
merged 16 commits into from
Apr 28, 2023
Merged

mmcls -> mmpretrain #2003

merged 16 commits into from
Apr 28, 2023

Conversation

huayuan4396
Copy link
Collaborator

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

mmcls -> mmpretrain

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Patch coverage: 59.37% and project coverage change: +0.03 🎉

Comparison is base (e9c0092) 49.65% compared to head (bbf37e5) 49.69%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2003      +/-   ##
==========================================
+ Coverage   49.65%   49.69%   +0.03%     
==========================================
  Files         339      339              
  Lines       12985    12976       -9     
  Branches     1901     1899       -2     
==========================================
  Hits         6448     6448              
+ Misses       6091     6080      -11     
- Partials      446      448       +2     
Flag Coverage Δ
unittests 49.69% <59.37%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmdeploy/codebase/__init__.py 82.35% <ø> (ø)
mmdeploy/codebase/mmpretrain/__init__.py 100.00% <ø> (ø)
mmdeploy/codebase/mmpretrain/deploy/__init__.py 100.00% <ø> (ø)
mmdeploy/codebase/mmpretrain/models/__init__.py 100.00% <ø> (ø)
...y/codebase/mmpretrain/models/backbones/__init__.py 100.00% <ø> (ø)
.../mmpretrain/models/backbones/vision_transformer.py 12.90% <0.00%> (ø)
...codebase/mmpretrain/models/classifiers/__init__.py 100.00% <ø> (ø)
...eploy/codebase/mmpretrain/models/necks/__init__.py 100.00% <ø> (ø)
mmdeploy/codebase/mmpretrain/models/necks/gap.py 58.33% <ø> (ø)
...eploy/codebase/mmpretrain/models/utils/__init__.py 100.00% <ø> (ø)
... and 7 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@RunningLeon
Copy link
Collaborator

@huayuan4396 Could sync with main branch and fix conficts at first

@RunningLeon RunningLeon requested a review from irexyc April 24, 2023 02:05
@RunningLeon
Copy link
Collaborator

@huayuan4396 could fix conflicts

@irexyc
Copy link
Collaborator

irexyc commented Apr 27, 2023

There are some files that maybe need to rename mmcls to mmpretrain.

docs/en/04-supported-codebases/mmpretrain.md
docs/zh_cn/04-supported-codebases/mmpretrain.md
docs/zh_cn/07-developer-guide/support_new_model.md
docs/zh_cn/01-how-to-build/cmake_option.md

some files that maybe need to rename mmclassification to mmpretrain

docs/en/03-benchmark/supported_models.md
docs/zh_cn/03-benchmark/supported_models.md
docs/zh_cn/02-how-to-run/prebuilt_package_windows.md
.github/scripts/quantize_to_ncnn.py
.github/scripts/test_onnx2ncnn.py

@huayuan4396
Copy link
Collaborator Author

Some md link would be dead since the mmpretrain file path has not been merged.

@RunningLeon
Copy link
Collaborator

Some md link would be dead since the mmpretrain file path has not been merged.

we could ignore lint error for doc links

Copy link
Collaborator

@irexyc irexyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@RunningLeon RunningLeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RunningLeon RunningLeon merged commit 840adcf into open-mmlab:main Apr 28, 2023
@huayuan4396 huayuan4396 deleted the dev branch May 4, 2023 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants