Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rknn and aarch64 build ci #1980

Merged
merged 3 commits into from
Apr 23, 2023
Merged

Fix rknn and aarch64 build ci #1980

merged 3 commits into from
Apr 23, 2023

Conversation

irexyc
Copy link
Collaborator

@irexyc irexyc commented Apr 12, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@RunningLeon
Copy link
Collaborator

may sync with main branch

@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (6325803) 49.44% compared to head (c8a12c5) 49.44%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1980   +/-   ##
=======================================
  Coverage   49.44%   49.44%           
=======================================
  Files         338      338           
  Lines       12920    12920           
  Branches     1897     1897           
=======================================
  Hits         6388     6388           
  Misses       6088     6088           
  Partials      444      444           
Flag Coverage Δ
unittests 49.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@RunningLeon
Copy link
Collaborator

@irexyc Is there something wrong with sync to main branch? the lint error still exists

@RunningLeon
Copy link
Collaborator

@irexyc could sync with main branch.

@RunningLeon RunningLeon added CI bug Something isn't working labels Apr 21, 2023
Copy link
Member

@AllentDan AllentDan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@RunningLeon RunningLeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RunningLeon RunningLeon merged commit 2c7e91b into open-mmlab:main Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants