Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(project): openvino upgrade to 2022.3.0 #1944

Merged
merged 1 commit into from
Mar 31, 2023
Merged

docs(project): openvino upgrade to 2022.3.0 #1944

merged 1 commit into from
Mar 31, 2023

Conversation

tpoisonooo
Copy link
Collaborator

@tpoisonooo tpoisonooo commented Mar 30, 2023 •
edited
Loading

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

  • upgrade openvino to 2022.3.0 to fix NMS loading error
  • update version description, some people would install 1.x branch instead of v1.0.0rc0

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@tpoisonooo tpoisonooo requested a review from lvhan028 March 30, 2023 11:08
@RunningLeon RunningLeon self-requested a review March 31, 2023 01:26
RunningLeon
RunningLeon approved these changes Mar 31, 2023
View reviewed changes
Copy link
Collaborator

@RunningLeon RunningLeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RunningLeon RunningLeon requested review from lvhan028 and AllentDan and removed request for lvhan028 March 31, 2023 04:14
AllentDan
AllentDan approved these changes Mar 31, 2023
View reviewed changes
Copy link
Member

@AllentDan AllentDan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RunningLeon RunningLeon added the documentation Improvements or additions to documentation label Mar 31, 2023
@RunningLeon RunningLeon merged commit 1411ed3 into open-mmlab:master Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AllentDan AllentDan AllentDan approved these changes

@RunningLeon RunningLeon RunningLeon approved these changes

@lvhan028 lvhan028 Awaiting requested review from lvhan028

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tpoisonooo @RunningLeon @AllentDan