Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Support auto release note #1589

Merged
merged 2 commits into from
Jan 10, 2023

Conversation

grimoire
Copy link
Member

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Support auto generate release note.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@grimoire grimoire added the improvement Improvement label Dec 29, 2022
@codecov
Copy link

codecov bot commented Dec 29, 2022

Codecov Report

Base: 44.81% // Head: 44.81% // No change to project coverage 👍

Coverage data is based on head (3b182d2) compared to base (f21dc4e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1589   +/-   ##
=======================================
  Coverage   44.81%   44.81%           
=======================================
  Files         356      356           
  Lines       12705    12705           
  Branches     1794     1794           
=======================================
  Hits         5694     5694           
  Misses       6618     6618           
  Partials      393      393           
Flag Coverage Δ
unittests 44.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zhiqwang
Copy link
Contributor

zhiqwang commented Dec 29, 2022

Great feature, does it automatically generate release reports based on each PR's labels when we publish release at GitHub?

@grimoire
Copy link
Member Author

@zhiqwang It depends on how you define report. https://docs.github.com/en/repositories/releasing-projects-on-github/automatically-generated-release-notes

Copy link
Collaborator

@RunningLeon RunningLeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lvhan028 lvhan028 requested a review from irexyc January 4, 2023 15:14
@lvhan028 lvhan028 merged commit 0737a59 into open-mmlab:master Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants