Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Remove cudnn dependency for transform 'mmaction2::format_shape' #1509

Merged
merged 4 commits into from
Dec 12, 2022
Merged

[Fix] Remove cudnn dependency for transform 'mmaction2::format_shape' #1509

merged 4 commits into from
Dec 12, 2022

Conversation

irexyc
Copy link
Collaborator

@irexyc irexyc commented Dec 9, 2022 •
edited
Loading

Motivation

  1. remove cudnn deps for mmaction2::format_shape
  2. fix FormatShape, it accept a list but return an object.
  3. FormatShape forget to init op.

@irexyc irexyc requested review from lvhan028 and lzhangzz December 9, 2022 07:34
@lvhan028 lvhan028 changed the title [Fix] Fix format_shape [Fix] Remove cudnn dependency for transform 'mmaction2::format_shape' Dec 12, 2022
@lvhan028 lvhan028 merged commit 52fd4fe into open-mmlab:master Dec 12, 2022
lvhan028 pushed a commit to lvhan028/mmdeploy that referenced this pull request Dec 12, 2022
@irexyc @lvhan028
[Fix] Remove cudnn dependency for transform 'mmaction2::format_shape' (…
6cf76f5 
…open-mmlab#1509)

* fix format shape

* merge common code

* use throw_exception

* udpate code format
(cherry picked from commit 52fd4fe)
lvhan028 pushed a commit to lvhan028/mmdeploy that referenced this pull request Dec 12, 2022
@irexyc @lvhan028
cherry-pick: Remove cudnn dependency for transform 'mmaction2::format…
57f7712 
…_shape' (open-mmlab#1509)
@lvhan028 lvhan028 mentioned this pull request Dec 13, 2022
Merged
2 tasks
lvhan028 added a commit that referenced this pull request Dec 13, 2022
@lvhan028
cherry-pick #1353 and #1509
78901a2 
cherry-pick #1353 and #1509 and resolve the build issues
lvhan028 pushed a commit that referenced this pull request Mar 1, 2023
@irexyc @lvhan028
cherry-pick: Remove cudnn dependency for transform 'mmaction2::format…
8dbb0fa 
…_shape' (#1509)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzhangzz lzhangzz lzhangzz approved these changes

@lvhan028 lvhan028 lvhan028 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@irexyc @lvhan028 @lzhangzz