Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix]: fix requirements of mmedit #1496

Merged
merged 4 commits into from
Dec 8, 2022
Merged

Conversation

RunningLeon
Copy link
Collaborator

@RunningLeon RunningLeon commented Dec 7, 2022

Motivation

fix requirements of mmedit

Modification

  • update required version in requirements/codebases.txt
  • fix clip not found in mmedit

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@lvhan028 lvhan028 mentioned this pull request Dec 7, 2022
Copy link
Collaborator

@lvhan028 lvhan028 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@grimoire grimoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grimoire grimoire merged commit 09c6bd7 into open-mmlab:dev-1.x Dec 8, 2022
lvhan028 pushed a commit that referenced this pull request Mar 1, 2023
* update requirements

* use github url

* fix mmcls ut

* install clip explicitly
@RunningLeon RunningLeon deleted the fix_ci branch December 21, 2023 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants