Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvements] Support TorchAllocator as TensorRT Gpu Allocator #1493

Merged
merged 3 commits into from
Dec 12, 2022

Conversation

grimoire
Copy link
Member

@grimoire grimoire commented Dec 6, 2022

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

PyTorch memory pool wastes lots of memories. The PR share the pool with TensorRT through custom IGpuAllocator.

a = torch.rand(large_memory_size, device='cuda')

del a

# torch would not release the pool, cudaMalloc might failed with OOM.
print(torch.cuda.memory_summary())

model = TRTWrapper(engine_path)

x = torch.rand(1, 3, 224, 224, device='cuda')
out = model(dict(input=x))

print(torch.cuda.memory_summary())

Modification

  • Custom IGpuAllocator wraps torch.cuda.caching_allocator_xxx.
  • TRTWrapper with custom allocator.
  • Fix bugs of MDCN

Got an error when applying the allocator on the Builder.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@grimoire grimoire requested review from AllentDan and lvhan028 and removed request for AllentDan December 7, 2022 11:56
@lvhan028 lvhan028 requested review from lzhangzz and removed request for lvhan028 December 8, 2022 02:47
Copy link
Member

@AllentDan AllentDan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mmdeploy/backend/tensorrt/torch_allocator.py Show resolved Hide resolved
mmdeploy/backend/tensorrt/torch_allocator.py Show resolved Hide resolved
@CLAassistant
Copy link

CLAassistant commented Dec 12, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@lzhangzz lzhangzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lzhangzz lzhangzz merged commit ac47cad into open-mmlab:master Dec 12, 2022
lvhan028 pushed a commit that referenced this pull request Dec 13, 2022
lvhan028 pushed a commit that referenced this pull request Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants