Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] MMRotate 1.x support #1401

Merged
merged 14 commits into from
Dec 12, 2022

Conversation

grimoire
Copy link
Member

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Support MMRotate in dev-1.x

Modification

  • update rewriters
  • refactor nms
  • documentation
  • sdk

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

docs/zh_cn/04-supported-codebases/mmrotate.md Outdated Show resolved Hide resolved
docs/en/04-supported-codebases/mmrotate.md Outdated Show resolved Hide resolved
mmdeploy/backend/sdk/export_info.py Outdated Show resolved Hide resolved
tests/test_codebase/test_mmdet/test_mmdet_models.py Outdated Show resolved Hide resolved
@RunningLeon
Copy link
Collaborator

@grimoire may need to fix conflicts

@grimoire
Copy link
Member Author

grimoire commented Dec 5, 2022

@RunningLeon @AllentDan @tpoisonooo Any comments?

AllentDan
AllentDan previously approved these changes Dec 7, 2022
Copy link
Member

@AllentDan AllentDan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tests/test_codebase/test_mmrotate/data/model.py Outdated Show resolved Hide resolved
@CLAassistant
Copy link

CLAassistant commented Dec 12, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@RunningLeon RunningLeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lvhan028 lvhan028 merged commit 2afbb99 into open-mmlab:dev-1.x Dec 12, 2022
lvhan028 pushed a commit that referenced this pull request Mar 1, 2023
* wip

* update twostage detector support

* fix unit test

* sdk wip

* comment

* refactor export info

* fix

* support roi trans

* update rotate.yml

* clear model.py, support torch1.13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants