Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]: add md link check github action #1320

Merged
merged 6 commits into from
Dec 8, 2022
Merged

[Enhancement]: add md link check github action #1320

merged 6 commits into from
Dec 8, 2022

Conversation

RunningLeon
Copy link
Collaborator

@RunningLeon RunningLeon commented Nov 8, 2022 •
edited
Loading

Motivation

Check dead links in documents at PR stage.

Modification

Add link check in lint ci.

BC-breaking (Optional)

None

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@lvhan028 lvhan028 requested review from tpoisonooo and lvhan028 and removed request for lvhan028 and tpoisonooo November 8, 2022 13:41
@RunningLeon RunningLeon changed the base branch from dev-1.x to 1.x December 1, 2022 10:34
@RunningLeon RunningLeon changed the base branch from 1.x to dev-1.x December 5, 2022 06:57
@RunningLeon RunningLeon changed the title [WIP]: add md link check action [Enhancement]: add md link check github action Dec 5, 2022
@RunningLeon
Copy link
Collaborator Author

@lvhan028 @AllentDan Hi, guys, any comment on this PR?

AllentDan
AllentDan approved these changes Dec 8, 2022
View reviewed changes
Copy link
Member

@AllentDan AllentDan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RunningLeon RunningLeon requested a review from lvhan028 December 8, 2022 08:07
@lvhan028 lvhan028 merged commit 25aa0d4 into open-mmlab:dev-1.x Dec 8, 2022
@labmanno004 labmanno004 mentioned this pull request Dec 8, 2022
Closed
3 tasks
lvhan028 pushed a commit that referenced this pull request Mar 1, 2023
@RunningLeon @lvhan028
[Enhancement]: add md link check github action (#1320)
f5216c0 
* add md link check action

* add config

* fix doc link

* fix dead links

* change dev-1.x to 1.x

* fix mmocr url
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AllentDan AllentDan AllentDan approved these changes

@lvhan028 lvhan028 lvhan028 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RunningLeon @lvhan028 @AllentDan