-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update c++17 #2865
update c++17 #2865
Conversation
Since cuda10 does not support c++17 and torch<=1.12 has cuda10.2 prebuild package, any environment with torch<=1.12 use c++14 |
Any updates? |
Hi @maxpain , this PR has been merged. |
@zhouzaida wow, thank you!! |
@zhouzaida When can we expect for a new version to be released? |
Hi @maxpain , we will release the mmcv2.1.0 when the pytorch v2.1.0 releases. |
@zhouzaida when the mmcv PyPi package with PyTorch 2.1.0 will be released so I can install it without building from source? |
We will provide these pre-built packages tomorrow. |
@zhouzaida any updates? |
Hi @maxpain, mmcv has released pre-built packages for torch2.1.0. Please install it with the following commands. pip install -U openmim
mim install mmcv |
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
#2860
Modification
comment constructor template of ShapeBase
c++14 -> c++17
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist
Before PR:
After PR: