Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update c++17 #2865

Merged
merged 4 commits into from
Sep 4, 2023
Merged

update c++17 #2865

merged 4 commits into from
Sep 4, 2023

Conversation

grimoire
Copy link
Member

@grimoire grimoire commented Jul 10, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

#2860

Modification

comment constructor template of ShapeBase
c++14 -> c++17

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

@grimoire grimoire linked an issue Jul 10, 2023 that may be closed by this pull request
2 tasks
@grimoire
Copy link
Member Author

Since cuda10 does not support c++17 and torch<=1.12 has cuda10.2 prebuild package, any environment with torch<=1.12 use c++14

@maxpain
Copy link

maxpain commented Aug 19, 2023

Any updates?

@Mxbonn Mxbonn mentioned this pull request Aug 30, 2023
@zhouzaida zhouzaida merged commit 6299bc0 into open-mmlab:main Sep 4, 2023
19 checks passed
@zhouzaida
Copy link
Collaborator

Any updates?

Hi @maxpain , this PR has been merged.

@maxpain
Copy link

maxpain commented Sep 4, 2023

@zhouzaida wow, thank you!!

@maxpain
Copy link

maxpain commented Sep 5, 2023

@zhouzaida When can we expect for a new version to be released?

@zhouzaida
Copy link
Collaborator

zhouzaida commented Sep 9, 2023

@zhouzaida When can we expect for a new version to be released?

Hi @maxpain , we will release the mmcv2.1.0 when the pytorch v2.1.0 releases.

@maxpain
Copy link

maxpain commented Oct 11, 2023

@zhouzaida when the mmcv PyPi package with PyTorch 2.1.0 will be released so I can install it without building from source?

@zhouzaida
Copy link
Collaborator

@zhouzaida when the mmcv PyPi package with PyTorch 2.1.0 will be released so I can install it without building from source?

We will provide these pre-built packages tomorrow.

@maxpain
Copy link

maxpain commented Oct 17, 2023

@zhouzaida any updates?

@zhouzaida
Copy link
Collaborator

Hi @maxpain, mmcv has released pre-built packages for torch2.1.0. Please install it with the following commands.

pip install -U openmim
mim install mmcv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing to build mmcv from source with cuda 12.1
3 participants