Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ops]Add three nn vector pool ops #2494

Open
wants to merge 2 commits into
base: 2.x
Choose a base branch
from

Conversation

VVsssssk
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Add three nn vector pool ops in 2.x branch.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects, like MMDet or MMCls.
  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Base: 66.70% // Head: 66.61% // Decreases project coverage by -0.08% ⚠️

Coverage data is based on head (3a39c2a) compared to base (d510b8b).
Patch coverage: 40.00% of modified lines in pull request are covered.

❗ Current head 3a39c2a differs from pull request most recent head f0b8a18. Consider uploading reports for the commit f0b8a18 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #2494      +/-   ##
==========================================
- Coverage   66.70%   66.61%   -0.09%     
==========================================
  Files         120      121       +1     
  Lines        7817     7842      +25     
  Branches     1072     1073       +1     
==========================================
+ Hits         5214     5224      +10     
- Misses       2436     2451      +15     
  Partials      167      167              
Flag Coverage Δ
unittests 66.61% <40.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmcv/ops/three_nn_vector_pool.py 37.50% <37.50%> (ø)
mmcv/ops/__init__.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


VVsssssk seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants