Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeCamp2023-369] Adding support for FastComposer #2011

Merged
merged 79 commits into from
Sep 11, 2023
Merged

[CodeCamp2023-369] Adding support for FastComposer #2011

merged 79 commits into from
Sep 11, 2023

Conversation

xiaomile
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Submitting this pull request means that,

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

xiaomile and others added 30 commits June 2, 2023 15:32
demo 示例
python mmagic\demo\mmagic_inference_demo.py --model-name deblurganv2 --model-comfig ../configs/deblurganv2/deblurganv2_fpn_inception.py --model-ckpt 权重文件路径 --img 测试图片路径 --device cpu --result-out-dir ./out.png
update model-index
CI test fix and update readme.md
fix CI test and update readme.md
代码调整,参数名保持一致
doc string coverage
add some doc string
add some doc string
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch coverage is 40.22% of modified lines.

❗ Current head 9f0bc70 differs from pull request most recent head 4bbacbb. Consider uploading reports for the commit 4bbacbb to get more accurate results

Files Changed Coverage
...c/models/editors/fastcomposer/fastcomposer_util.py 35.21%
mmagic/models/editors/fastcomposer/fastcomposer.py 50.00%
mmagic/models/editors/__init__.py 100.00%
mmagic/models/editors/fastcomposer/__init__.py 100.00%

📢 Thoughts on this report? Let us know!.

@xiaomile
Copy link
Contributor Author

xiaomile commented Sep 1, 2023

@liuwenran Hi, I followed your advice and made the changes, but the CI test on minimum_version_cpu still complains out of the memory. Could it be because I loaded a CLIP image encoder model?

@liuwenran
Copy link
Collaborator

@liuwenran Hi, I followed your advice and made the changes, but the CI test on minimum_version_cpu still complains out of the memory. Could it be because I loaded a CLIP image encoder model?

yes, try not to use "clip_vit_url = 'openai/clip-vit-large-patch14' ", maybe change it to vit base or smaller clip resnet50 model

@liuwenran liuwenran closed this Sep 4, 2023
@liuwenran liuwenran reopened this Sep 4, 2023
add example code which run without gradio to readme
add config of clip for running unittest without using "clip_vit_url = 'openai/clip-vit-large-patch14' "
rerun checks of build cu102
mmagic/apis/mmagic_inferencer.py Outdated Show resolved Hide resolved
demo/gradio_fastcomposer.py Show resolved Hide resolved
@xiaomile
Copy link
Contributor Author

xiaomile commented Sep 8, 2023

Hi @liuwenran ,requested changes were completed.

demo/gradio_fastcomposer.py Show resolved Hide resolved
demo/gradio_fastcomposer.py Show resolved Hide resolved
configs/fastcomposer/README.md Show resolved Hide resolved
 add device for running with cuda by default
Copy link
Collaborator

@liuwenran liuwenran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution bro!

@liuwenran liuwenran merged commit afc71ed into open-mmlab:main Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants