-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] Requirements #1899
[Fix] Requirements #1899
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1899 +/- ##
==========================================
- Coverage 82.95% 82.94% -0.02%
==========================================
Files 412 412
Lines 27673 27673
Branches 4332 4332
==========================================
- Hits 22956 22952 -4
- Misses 3774 3778 +4
Partials 943 943
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
@Z-Fran Hi, I notice that in mmagic/mmagic/engine/init.py, the minimal version of MMCV is asserted to be "2.0.0rc1". |
Actually, it should also be modified to 2.0.0 here. |
May I change all these "2.0.0rc1" to "2.0.0"? |
Remove
mmcv
andmmengine
from "requirements/runtime.txt"mmcv
andmmengine
are repeatedly listed in "requirements/{mminstall.txt,runtime.txt}". Following MMDetection, we removedmmcv
andmmengine
from "requirements/runtime.txt", and kept those in "requirements/mminstall.txt".The reason is that we have manually installed MMCV and MMEngine before installing MMagic as indicated in the Doc. As a result, there is no need to require
mmcv
andmmengine
in "requirements/runtime.txt", which are to be installed with "setup.py".After this modification, the installation of MMagic is much faster.
Add dependencies Click and pandas in "requirements/runtime.txt"
We added
Click
andpandas
in "requirements/runtime.txt". They are required by "mmagic/utils/io_utils.py" and "mmagic/models/editors/disco_diffusion/guider.py".These two packages are installed when installing MIM. However, when someone uses pip instead of MIM to install MMCV, these two packages are missed and cannot be found.