Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeCamp #83] Support Restormer model #1503

Merged
merged 44 commits into from
Dec 21, 2022
Merged

Conversation

AlexZou14
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Support Restormer of image restoration
Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

Who can help? @ them here!

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with some of those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Base: 60.70% // Head: 88.09% // Increases project coverage by +27.38% 🎉

Coverage data is based on head (9639b5c) compared to base (00852b2).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##           dev-1.x    #1503       +/-   ##
============================================
+ Coverage    60.70%   88.09%   +27.38%     
============================================
  Files          326      385       +59     
  Lines        19974    24358     +4384     
  Branches      3330     3811      +481     
============================================
+ Hits         12126    21458     +9332     
+ Misses        7445     2081     -5364     
- Partials       403      819      +416     
Flag Coverage Δ
unittests 88.09% <ø> (+27.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...edit/models/editors/pconv/pconv_encoder_decoder.py 76.19% <0.00%> (-17.15%) ⬇️
.../models/editors/global_local/gl_encoder_decoder.py 88.00% <0.00%> (-12.00%) ⬇️
mmedit/models/losses/pixelwise_loss.py 94.59% <0.00%> (-5.41%) ⬇️
mmedit/datasets/transforms/crop.py 85.38% <0.00%> (-2.36%) ⬇️
mmedit/datasets/transforms/formatting.py 84.71% <0.00%> (-1.86%) ⬇️
mmedit/registry.py 100.00% <0.00%> (ø)
mmedit/utils/typing.py 100.00% <0.00%> (ø)
mmedit/apis/__init__.py 100.00% <0.00%> (ø)
mmedit/utils/__init__.py 100.00% <0.00%> (ø)
mmedit/engine/__init__.py 100.00% <0.00%> (ø)
... and 283 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

configs/_base_/datasets/deblurring_test_config.py Outdated Show resolved Hide resolved
configs/_base_/datasets/deblurring_test_config.py Outdated Show resolved Hide resolved
configs/_base_/datasets/deraining_test_config.py Outdated Show resolved Hide resolved
configs/_base_/datasets/deraining_test_config.py Outdated Show resolved Hide resolved
configs/_base_/datasets/deraining_test_config.py Outdated Show resolved Hide resolved
Z-Fran
Z-Fran previously approved these changes Dec 12, 2022
@CLAassistant
Copy link

CLAassistant commented Dec 12, 2022

CLA assistant check
All committers have signed the CLA.

@Z-Fran Z-Fran requested a review from plyfager December 19, 2022 04:38
@Z-Fran Z-Fran merged commit b13cd06 into open-mmlab:dev-1.x Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants