Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] unpaired_image_dataset.py conduct random sampling in training + some urls are wrong in cyclegan's README. #1307

Closed
3 tasks done
LeoXing1996 opened this issue Oct 15, 2022 · 1 comment · Fixed by #1308
Assignees
Labels
kind/bug something isn't working priority/P0 highest priority status/WIP work in progress normally
Milestone

Comments

@LeoXing1996
Copy link
Collaborator

Prerequisite

Task

I'm using the official example scripts/configs for the officially supported tasks/models/datasets.

Branch

1.x branch https://github.com/open-mmlab/mmediting/tree/1.x

Environment

pytorch-1.11.0-pytorch
mmcv-2.0.0-rc1
mmengine-0.1.0

Reproduces the problem - code sample

    def get_data_info(self, idx) -> dict:
        img_a_path = self.data_infos_a[idx % self.len_a]['path']
        if self.test_mode:
            idx_b = np.random.randint(0, self.len_b)
            img_b_path = self.data_infos_b[idx_b]['path']
        else:
            img_b_path = self.data_infos_b[idx % self.len_b]['path']
        data_info = dict()
        data_info[f'img_{self.domain_a}_path'] = img_a_path
        data_info[f'img_{self.domain_b}_path'] = img_b_path
        return data_info

Reproduces the problem - command or script

bash tools/slurm_train.sh PARTITION JOB_NAME config/cyclegan/cyclegan_lsgan-id0-resnet-in_1xb1-250kiters_summer2winter.py work_dirs/train_benchmark

Reproduces the problem - error message

The performance is much worse than expected.

Additional information

No response

@LeoXing1996 LeoXing1996 added kind/bug something isn't working status/WIP work in progress normally priority/P0 highest priority labels Oct 15, 2022
@LeoXing1996 LeoXing1996 added this to the 1.0.0rc2 milestone Oct 15, 2022
@LeoXing1996 LeoXing1996 self-assigned this Oct 15, 2022
@zengyh1900
Copy link
Collaborator

Fixed in #1308.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug something isn't working priority/P0 highest priority status/WIP work in progress normally
Projects
None yet
2 participants