Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Fast RCNN #351

Merged
merged 186 commits into from
Dec 18, 2020
Merged

[Feature] Fast RCNN #351

merged 186 commits into from
Dec 18, 2020

Conversation

kennymckormick
Copy link
Member

No description provided.

@kennymckormick kennymckormick added the WIP work in progress label Nov 17, 2020
@codecov
Copy link

codecov bot commented Nov 17, 2020

Codecov Report

Merging #351 (95edd8f) into master (562c759) will decrease coverage by 1.90%.
The diff coverage is 73.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #351      +/-   ##
==========================================
- Coverage   86.59%   84.69%   -1.91%     
==========================================
  Files         101      118      +17     
  Lines        7201     8344    +1143     
  Branches     1161     1366     +205     
==========================================
+ Hits         6236     7067     +831     
- Misses        733      930     +197     
- Partials      232      347     +115     
Flag Coverage Δ
unittests 84.68% <73.96%> (-1.91%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmaction/datasets/pipelines/__init__.py 100.00% <ø> (ø)
mmaction/models/heads/roi_head.py 28.88% <28.88%> (ø)
mmaction/models/builder.py 55.26% <36.36%> (-9.03%) ⬇️
mmaction/core/evaluation/ava_evaluation/metrics.py 46.15% <46.15%> (ø)
...tion/core/evaluation/ava_evaluation/np_box_list.py 47.72% <47.72%> (ø)
mmaction/models/backbones/resnet3d_slowfast.py 84.70% <50.00%> (-3.27%) ⬇️
...action/core/bbox/assigners/max_iou_assigner_ava.py 52.08% <52.08%> (ø)
mmaction/models/backbones/resnet3d_slowonly.py 80.00% <62.50%> (-20.00%) ⬇️
...tion/ava_evaluation/object_detection_evaluation.py 65.42% <65.42%> (ø)
mmaction/datasets/pipelines/formating.py 89.74% <66.66%> (-4.92%) ⬇️
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 562c759...95edd8f. Read the comment docs.

@kennymckormick kennymckormick changed the title [WIP] [Feature] Fast rcnn [WIP] [Feature] Fast RCNN Nov 19, 2020
@kennymckormick
Copy link
Member Author

Btw, please first ping me rather than directly merge it if you think the code part is OK. Since config and modelzoo are not updated now. @innerlee

@innerlee
Copy link
Contributor

Okay,

@innerlee
Copy link
Contributor

@kennymckormick ready for merge?

@dreamerlin dreamerlin added exist conflict This PR exists conflicts to be resolved need changelog labels Dec 18, 2020
@kennymckormick kennymckormick removed the exist conflict This PR exists conflicts to be resolved label Dec 18, 2020
@kennymckormick kennymckormick removed WIP work in progress need changelog labels Dec 18, 2020
@kennymckormick
Copy link
Member Author

@innerlee ready now

@innerlee innerlee merged commit f4b165b into open-mmlab:master Dec 18, 2020
@kennymckormick kennymckormick deleted the FastRCNN branch December 21, 2020 03:46
@kennymckormick kennymckormick linked an issue Dec 25, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do you have the plan to add the person detection function
4 participants