[Feature] Add GradCAM utils for Recognizer. #324

irvingzhang0512 · 2020-11-09T07:37:07Z

add unittest
test generating heatmaps with labels.

CLAassistant · 2020-11-09T07:37:14Z

All committers have signed the CLA.

codecov · 2020-11-09T08:42:45Z

Codecov Report

Merging #324 (76fb7b0) into master (a02a8de) will increase coverage by 0.15%.
The diff coverage is 95.23%.

@@            Coverage Diff             @@
##           master     #324      +/-   ##
==========================================
+ Coverage   85.81%   85.97%   +0.15%     
==========================================
  Files          97       98       +1     
  Lines        6797     6922     +125     
  Branches     1104     1118      +14     
==========================================
+ Hits         5833     5951     +118     
- Misses        749      753       +4     
- Partials      215      218       +3

Flag	Coverage Δ
unittests	`85.95% <95.23%> (+0.15%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
mmaction/models/recognizers/audio_recognizer.py	`62.50% <50.00%> (-0.66%)`	⬇️
mmaction/models/recognizers/base.py	`58.82% <85.71%> (+1.53%)`	⬆️
mmaction/models/recognizers/recognizer2d.py	`88.05% <95.00%> (+2.95%)`	⬆️
mmaction/utils/gradcam_utils.py	`96.55% <96.55%> (ø)`
mmaction/models/recognizers/recognizer3d.py	`89.74% <100.00%> (+3.07%)`	⬆️
mmaction/utils/__init__.py	`100.00% <100.00%> (ø)`
mmaction/core/evaluation/accuracy.py	`91.90% <0.00%> (-0.96%)`	⬇️
mmaction/models/backbones/resnet2plus1d.py	`100.00% <0.00%> (+4.00%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13f50f7...907a176. Read the comment docs.

tests/test_models/test_recognizers.py

mmaction/utils/gradcam_utils.py

demo/demo_gradcam.py

mmaction/models/recognizers/recognizer3d.py

mmaction/utils/gradcam_utils.py

SuX97 · 2020-11-09T09:33:03Z

Cool.

… gradcam

2. add reisze params in demo_gradcam.py. 3. smaller demo_gradcam.gif. 4. add unittest for `GradCAM` & `forward_gradcam`. 5. add more docs.

irvingzhang0512 · 2020-11-10T09:56:19Z

@SuX97
I'm not familiar with unittest...
It seems that test_bmn fails, but I cannot find why.
Any suggestions?

tests/test_gradcam.py

dreamerlin · 2020-11-10T10:00:06Z

@SuX97
I'm not familiar with unittest...
It seems that test_bmn fails, but I cannot find why.
Any suggestions?

Some data shapes are too huge, which may cause failure in CI.

demo/demo_gradcam.py

docs/changelog.md

mmaction/utils/gradcam_utils.py

tests/test_gradcam.py

mmaction/utils/gradcam_utils.py

tests/test_gradcam.py

dreamerlin · 2020-11-10T13:15:17Z

The docs about demo can be moved to demo/README.md

mmaction/utils/gradcam_utils.py

demo/demo_gradcam.py

mmaction/utils/gradcam_utils.py

demo/demo_gradcam.py

dreamerlin · 2020-11-11T07:42:12Z

Please also help to highlight that the demo can also loads checkpoint from corresponding url, like this. thanks!

mmaction/utils/gradcam_utils.py

… gradcam

mmaction/utils/gradcam_utils.py

dreamerlin · 2020-11-11T15:40:29Z

LGTM

… gradcam

mmaction/models/recognizers/base.py

SuX97

LGTM.

innerlee · 2020-11-12T13:50:54Z

This is a big pr, thanks!

innerlee · 2020-11-12T13:51:33Z

good to go after resolving the conflicts

dreamerlin · 2020-11-12T13:53:15Z

good to go after resolving the conflicts

Help with resolving conflicts

[Feature] Add GradCAM utils for Recognizer.

e9ba9c0

[Fix] abstract forward gradcam bug.

13b897a

innerlee requested a review from SuX97 November 9, 2020 08:35

SuX97 reviewed Nov 9, 2020

View reviewed changes

tests/test_models/test_recognizers.py Show resolved Hide resolved

SuX97 reviewed Nov 9, 2020

View reviewed changes

mmaction/utils/gradcam_utils.py Outdated Show resolved Hide resolved

SuX97 reviewed Nov 9, 2020

View reviewed changes

demo/demo_gradcam.py Show resolved Hide resolved

SuX97 reviewed Nov 9, 2020

View reviewed changes

demo/demo_gradcam.py Outdated Show resolved Hide resolved

SuX97 reviewed Nov 9, 2020

View reviewed changes

mmaction/models/recognizers/recognizer3d.py Outdated Show resolved Hide resolved

SuX97 reviewed Nov 9, 2020

View reviewed changes

mmaction/utils/gradcam_utils.py Outdated Show resolved Hide resolved

SuX97 reviewed Nov 9, 2020

View reviewed changes

mmaction/utils/gradcam_utils.py Outdated Show resolved Hide resolved

SuX97 added need docstring need test labels Nov 9, 2020

irvingzhang0512 added 2 commits November 10, 2020 16:24

Merge branch 'master' of https://github.com/open-mmlab/mmaction2 into…

a89a41e

… gradcam

1. update codes based on reviewer suggestions.

083d145

2. add reisze params in demo_gradcam.py. 3. smaller demo_gradcam.gif. 4. add unittest for `GradCAM` & `forward_gradcam`. 5. add more docs.

dreamerlin reviewed Nov 10, 2020

View reviewed changes

tests/test_gradcam.py Outdated Show resolved Hide resolved

smaller input data shapes for unittest

d332436

dreamerlin reviewed Nov 10, 2020

View reviewed changes

irvingzhang0512 added 2 commits November 11, 2020 00:13

Merge branch 'master' into gradcam

e8ebd4b

modify codes based on reviewer's suggestions.

9d44bbd

irvingzhang0512 requested a review from dreamerlin November 11, 2020 02:47

dreamerlin reviewed Nov 11, 2020

View reviewed changes

mmaction/utils/gradcam_utils.py Outdated Show resolved Hide resolved

demo/demo_gradcam.py Outdated Show resolved Hide resolved

dreamerlin requested review from SuX97 and innerlee November 11, 2020 04:06

innerlee reviewed Nov 11, 2020

View reviewed changes

mmaction/utils/gradcam_utils.py Outdated Show resolved Hide resolved

innerlee reviewed Nov 11, 2020

View reviewed changes

demo/demo_gradcam.py Outdated Show resolved Hide resolved

dreamerlin removed need docstring need test labels Nov 11, 2020

dreamerlin reviewed Nov 11, 2020

View reviewed changes

mmaction/utils/gradcam_utils.py Outdated Show resolved Hide resolved

irvingzhang0512 added 2 commits November 11, 2020 18:44

Merge branch 'master' of https://github.com/open-mmlab/mmaction2 into…

62a87fc

… gradcam

update codes after reviewers' suggestions.

414837c

dreamerlin reviewed Nov 11, 2020

View reviewed changes

mmaction/utils/gradcam_utils.py Show resolved Hide resolved

dreamerlin added exist conflict This PR exists conflicts to be resolved need changelog and removed need changelog labels Nov 11, 2020

irvingzhang0512 added 2 commits November 12, 2020 09:07

Merge branch 'master' of https://github.com/open-mmlab/mmaction2 into…

8a2e962

… gradcam

update codes after reviewer's suggestions.

c2e0ecf

dreamerlin approved these changes Nov 12, 2020

View reviewed changes

dreamerlin removed the exist conflict This PR exists conflicts to be resolved label Nov 12, 2020

SuX97 reviewed Nov 12, 2020

View reviewed changes

mmaction/models/recognizers/base.py Outdated Show resolved Hide resolved

SuX97 approved these changes Nov 12, 2020

View reviewed changes

remove gradcam in BaseRecognition forward.

515240d

Merge branch 'master' into gradcam

907a176

innerlee merged commit 8ba6253 into open-mmlab:master Nov 12, 2020

wwdok mentioned this pull request Jan 6, 2021

Video GradCAM Demo is prone to get CUDA out of memory with more than 32 frames #519

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Feature] Add GradCAM utils for Recognizer. #324

[Feature] Add GradCAM utils for Recognizer. #324

irvingzhang0512 commented Nov 9, 2020 •

edited

Loading

CLAassistant commented Nov 9, 2020 •

edited

Loading

codecov bot commented Nov 9, 2020 •

edited

Loading

SuX97 commented Nov 9, 2020

irvingzhang0512 commented Nov 10, 2020

dreamerlin commented Nov 10, 2020

dreamerlin commented Nov 10, 2020

dreamerlin commented Nov 11, 2020

dreamerlin commented Nov 11, 2020

SuX97 left a comment

innerlee commented Nov 12, 2020

innerlee commented Nov 12, 2020

dreamerlin commented Nov 12, 2020

[Feature] Add GradCAM utils for Recognizer. #324

[Feature] Add GradCAM utils for Recognizer. #324

Conversation

irvingzhang0512 commented Nov 9, 2020 • edited Loading

CLAassistant commented Nov 9, 2020 • edited Loading

codecov bot commented Nov 9, 2020 • edited Loading

Codecov Report

SuX97 commented Nov 9, 2020

irvingzhang0512 commented Nov 10, 2020

dreamerlin commented Nov 10, 2020

dreamerlin commented Nov 10, 2020

dreamerlin commented Nov 11, 2020

dreamerlin commented Nov 11, 2020

SuX97 left a comment

Choose a reason for hiding this comment

innerlee commented Nov 12, 2020

innerlee commented Nov 12, 2020

dreamerlin commented Nov 12, 2020

irvingzhang0512 commented Nov 9, 2020 •

edited

Loading

CLAassistant commented Nov 9, 2020 •

edited

Loading

codecov bot commented Nov 9, 2020 •

edited

Loading