Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge dev-1.x to 1.x #2217

Merged
merged 11 commits into from
Feb 10, 2023
Merged

Merge dev-1.x to 1.x #2217

merged 11 commits into from
Feb 10, 2023

Conversation

ly015
Copy link
Member

@ly015 ly015 commented Feb 10, 2023

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily got feedback.
If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduces changes that break the back-compatibility of this repo?
If so, please describe how it breaks the compatibility and how users should modify their codes to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools should be used to fix the potential lint issues.
  2. The modification should be covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation should be modified accordingly, like docstring or example tutorials.

@ly015 ly015 changed the base branch from master to 1.x February 10, 2023 13:59
@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Base: 75.99% // Head: 76.15% // Increases project coverage by +0.16% 🎉

Coverage data is based on head (d24701c) compared to base (215378c).
Patch coverage: 75.27% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##              1.x    #2217      +/-   ##
==========================================
+ Coverage   75.99%   76.15%   +0.16%     
==========================================
  Files         151      157       +6     
  Lines       11376    12121     +745     
  Branches     1881     1997     +116     
==========================================
+ Hits         8645     9231     +586     
- Misses       2298     2429     +131     
- Partials      433      461      +28     
Flag Coverage Δ
unittests 76.15% <75.27%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmaction/engine/hooks/visualization_hook.py 30.61% <0.00%> (ø)
...ptimizers/layer_decay_optim_wrapper_constructor.py 19.64% <19.64%> (ø)
mmaction/models/backbones/mvit.py 78.81% <26.47%> (-5.26%) ⬇️
mmaction/models/heads/timesformer_head.py 81.81% <33.33%> (-18.19%) ⬇️
mmaction/datasets/transforms/loading.py 81.22% <41.66%> (+0.32%) ⬆️
mmaction/visualization/action_visualizer.py 70.19% <45.45%> (+2.23%) ⬆️
mmaction/datasets/activitynet_dataset.py 45.45% <50.00%> (ø)
mmaction/datasets/repeat_aug_dataset.py 75.86% <60.00%> (-8.14%) ⬇️
...maction/apis/inferencers/actionrecog_inferencer.py 74.07% <74.07%> (ø)
mmaction/apis/inference.py 44.57% <75.00%> (+0.82%) ⬆️
... and 28 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ly015 ly015 merged commit 71715b6 into 1.x Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants