Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] switch mmaction2totorchserve from mmcv to mmengine #2053

Merged
merged 2 commits into from
Nov 25, 2022

Conversation

austinmw
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily got feedback.
If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Fix deploy script for v1.0

Modification

switch mmcv to mmengine where appropriate

Checklist

  1. Pre-commit or other linting tools should be used to fix the potential lint issues.
  2. The modification should be covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation should be modified accordingly, like docstring or example tutorials.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ly015 ly015 requested a review from cir7 November 14, 2022 07:25
@ly015 ly015 added the 1.x Issue/PR related to branch 1.x label Nov 14, 2022
@ly015
Copy link
Member

ly015 commented Nov 14, 2022

Thank you very much for contributing to mmaction2.0. We will review this PR asap. Meanwhile, could you please sign the CLA so we can merge your code into mmaction2?

@Dai-Wenxun Dai-Wenxun changed the title switch mmaction2totorchserve from mmcv to mmengine [Fix] switch mmaction2totorchserve from mmcv to mmengine Nov 24, 2022
@ly015 ly015 merged commit 94ed608 into open-mmlab:dev-1.x Nov 25, 2022
ly015 pushed a commit that referenced this pull request Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x Issue/PR related to branch 1.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants