[Feature] add cfg_name in meta info
#183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #183 +/- ##
=======================================
Coverage 84.14% 84.14%
=======================================
Files 79 79
Lines 4975 4975
Branches 789 789
=======================================
Hits 4186 4186
Misses 663 663
Partials 126 126
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
dreamerlin
force-pushed
the
exp_name
branch
from
3f08226 to
74ee53a
Compare
dreamerlin
changed the title
cfg_name in meta info
innerlee
approved these changes
Sep 23, 2020
|
two comments:
|
innerlee
reviewed
Sep 23, 2020
tools/train.py
Outdated
| @@ -120,7 +120,8 @@ def main(): | |||
| set_random_seed(args.seed, deterministic=args.deterministic) | |||
| cfg.seed = args.seed | |||
| meta['seed'] = args.seed | |||
| meta['cfg_name'] = osp.basename(args.config) | |||
| meta['config_name'] = osp.basename(args.config) | |||
| meta['work_dir'] = osp.abspath(cfg.work_dir) | |||
There was a problem hiding this comment.
for privacy reasons, dir name of the work dir is good. you can use os.path.basename(blablah.rstrip('/\\'))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.