Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Add deactivate SSL certification verity option #179

Merged
merged 12 commits into from
Dec 24, 2022

Conversation

kim3321
Copy link
Contributor

@kim3321 kim3321 commented Dec 11, 2022

Enables to disable ssl certificate checking

Motivation

Add the option not to check ssl certificate to allow downloads to be performed in environments where ssl errors occur (for example, on-premises)

Modification

Some codes have been modified so that the requests module can select whether to check the ssl certificate or not module.

Use cases

mim download mmcls --no-check-certificate --config resnet18_8xb16_cifar10 --dest .

@kim3321 kim3321 changed the title Kim3321/ignore ssl check [Enhancement] Add deactivate SSL certification verity option Dec 11, 2022
@zhouzaida zhouzaida requested a review from ice-tong December 12, 2022 06:35
@ice-tong
Copy link
Collaborator

Hi @kim3321 , sorry for the late reply. ^_^

This changes looks grate to me, thanks for your contribution!

README.md Outdated Show resolved Hide resolved
Modify download command in Readme.md
README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@ice-tong ice-tong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

mim/commands/download.py Outdated Show resolved Hide resolved
mim/commands/download.py Outdated Show resolved Hide resolved
mim/commands/download.py Outdated Show resolved Hide resolved
mim/utils/utils.py Outdated Show resolved Hide resolved
mim/utils/utils.py Outdated Show resolved Hide resolved
mim/commands/download.py Outdated Show resolved Hide resolved
Co-authored-by: Zaida Zhou <58739961+zhouzaida@users.noreply.github.com>
@zhouzaida
Copy link
Collaborator

Hi, the lint failed.

@zhouzaida zhouzaida merged commit 7293369 into open-mmlab:main Dec 24, 2022
@openmmlab-bot
Copy link
Collaborator

Dear kim3321,
First of all, we want to express our gratitude for your significant PR in the MIM project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.
We are looking forward to continuing our collaboration with you. OpenMMLab has established a special contributors' organization called MMSIG, which provides contributors with open-source certificates, a recognition system, and exclusive rewards. You can contact us by adding our WeChat(if you have WeChat): openmmlabwx, or join in our discord:https://discord.gg/raweFPmdzG. We sincerely hope you will join us!
Best regards! @kim3321

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants