Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix packaging #145

Merged
merged 2 commits into from
Jun 27, 2022
Merged

Fix packaging #145

merged 2 commits into from
Jun 27, 2022

Conversation

zhouzaida
Copy link
Collaborator

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

  • build wheel package when publish to pypi
  • include requirements/*.txt when packaging

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the back-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #145 (8df40f6) into main (b449e97) will not change coverage.
The diff coverage is n/a.

❗ Current head 8df40f6 differs from pull request most recent head c0260ad. Consider uploading reports for the commit c0260ad to get more accurate results

@@           Coverage Diff           @@
##             main     #145   +/-   ##
=======================================
  Coverage   54.44%   54.44%           
=======================================
  Files          23       23           
  Lines        1552     1552           
  Branches      331      331           
=======================================
  Hits          845      845           
  Misses        582      582           
  Partials      125      125           
Flag Coverage Δ
unittests 54.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b449e97...c0260ad. Read the comment docs.

@zhouzaida zhouzaida merged commit b46d2c9 into open-mmlab:main Jun 27, 2022
@zhouzaida zhouzaida deleted the fix-packaging branch June 27, 2022 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant