Replace data package with /external/ git submodules #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
behnam
commented
Jan 6, 2019
There was a problem hiding this comment.
bors: r+
Reviewed 88 of 88 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
bors bot
added a commit
that referenced
this pull request
Jan 6, 2019
247: Replace data package with /external/ git submodules r=behnam a=behnam As we have now git repositories for the published data sources used in UNIC, we can replace our custom download package with git submodules, which are easier to maintain and provide more flexibility in dev time. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/open-i18n/rust-unic/247) <!-- Reviewable:end --> Co-authored-by: Behnam Esfahbod <behnam@zwnj.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we have now git repositories for the published data sources used in UNIC, we can replace our custom download package with git submodules, which are easier to maintain and provide more flexibility in dev time.
This change is