Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ucd/ident: Add test for Pattern Syntax/Whitespace data #254

Closed
declanvk opened this issue Feb 7, 2019 · 2 comments
Closed

ucd/ident: Add test for Pattern Syntax/Whitespace data #254

declanvk opened this issue Feb 7, 2019 · 2 comments
Labels
A: test Testing C: identifier Unicode Identifier and Pattern Syntax good first issue help wanted
Milestone
UNIC-0.10

Comments

@declanvk
Copy link
Contributor

declanvk commented Feb 7, 2019

Hello,

I noticed that the pattern whitespace property is incorrectly using the pattern_syntax.rsv table.

rust-unic/unic/ucd/ident/src/lib.rs

Lines 125 to 131 in 6c6702a

pub struct PatternWhitespace(bool) {
abbr => "Pat_WS";
long => "Pattern_White_Space";
human => "Pattern Whitespace";
data_table_path => "../tables/pattern_syntax.rsv";
}

I've opened a PR with the simple substitution, #253

Thanks,
Declan
@declanvk declanvk mentioned this issue Feb 7, 2019
Closed
bors bot added a commit that referenced this issue Feb 7, 2019
@bors @declanvk
Merge #253
2da0799 
253: Fix issue with Pattern Whitespace r=CAD97 a=declanvk

Fixes issue #254 

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/open-i18n/rust-unic/253)
<!-- Reviewable:end -->


Co-authored-by: Declan Kelly <dkelly.home@gmail.com>
bors bot added a commit that referenced this issue Feb 25, 2019
@bors @declanvk
Merge #253
fd52fb9 
253: Fix issue with Pattern Whitespace r=behnam a=declanvk

Fixes issue #254 

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/open-i18n/rust-unic/253)
<!-- Reviewable:end -->


Co-authored-by: Declan Kelly <dkelly.home@gmail.com>
@behnam
Copy link
Member

behnam commented Feb 25, 2019

Thanks, @declanvk, for filing the issue!

Unfortunately we haven't had unit tests for these tables, hence not catching the problem earlier. Fix is being landed in #255, but let's keep this open to also add some basic unit tests!

@behnam behnam added help wanted A: test Testing C: identifier Unicode Identifier and Pattern Syntax good first issue labels Feb 25, 2019
@behnam behnam added this to the UNIC-0.9 milestone Feb 25, 2019
@behnam behnam changed the title Pattern Whitespace Uses Incorrect Data Table ucd/ident: Add test for Pattern Syntax/Whitespace data Feb 25, 2019
@behnam behnam mentioned this issue Mar 3, 2019
Merged
bors bot added a commit that referenced this issue Mar 3, 2019
@bors @behnam
Merge #257
2fa4706 
257: ucd/ident: Split into modules and add unit tests r=behnam a=behnam

Resolves GH-254.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/open-i18n/rust-unic/257)
<!-- Reviewable:end -->


Co-authored-by: Behnam Esfahbod <behnam@zwnj.org>
@bors bors bot closed this as completed in #257 Mar 3, 2019
@behnam behnam reopened this Mar 3, 2019
@behnam
Copy link
Member

behnam commented Mar 3, 2019

I'm going to make a release, v0.9.0, soon, to deploy the fix for this.

@behnam behnam closed this as completed Mar 3, 2019
@behnam behnam mentioned this issue Mar 3, 2019
Merged
bors bot added a commit that referenced this issue Mar 3, 2019
@bors @behnam
Merge #258
89f5f55 
258: Release v0.9.0 r=behnam a=behnam

### Add

- `unic-ucd-name_aliases`: Unicode Name Alias character properties.

### Changed

- `unic-cli`: Fallback to  Name Alias for characters without Name value.

### Fixed

- `ucd-ident`: Use correct data table for `PatternWhitespace` property.
  [[GH-254](#254)]

### Misc

- Use external git submodules for source data.

- Migrate to Rust 2018 Edition.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/open-i18n/rust-unic/258)
<!-- Reviewable:end -->


Co-authored-by: Behnam Esfahbod <behnam@zwnj.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A: test Testing C: identifier Unicode Identifier and Pattern Syntax good first issue help wanted
Projects
None yet
Milestone
UNIC-0.10
Development

No branches or pull requests
2 participants
@behnam @declanvk