Issue #4261 - Fix CWE-73: File Manipulation #4262
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yummikko
force-pushed
the
fix_1538_file_manipulation
branch
4 times, most recently
from
46a55d8 to
d3c39d7
Compare
LiilyZhang
reviewed
Mar 6, 2025
Yummikko
force-pushed
the
fix_1538_file_manipulation
branch
from
a506382 to
cef683c
Compare
LiilyZhang
requested changes
Mar 10, 2025
|
@Yummikko Changes look good. Please squash the commits, thank you! |
Yummikko
force-pushed
the
fix_1538_file_manipulation
branch
2 times, most recently
from
7f5afd5 to
e4ca71c
Compare
Signed-off-by: Aleksandra Chyła <aleksandra.chyla@ibm.com>
Yummikko
force-pushed
the
fix_1538_file_manipulation
branch
from
1ab7a24 to
0984595
Compare
LiilyZhang
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR improves the security of the DeleteStoredData function by properly sanitizing file path before deletion. It addresses a file manipulation vulnerability (CWE-73) flagged by security scans, preventing potential path traversal attacks.
CWE Description
File Manipulation vulnerability occurs when an application allows user input to control or influence paths or file names that are used in file system operations. This could allow an attacker to access or modify system files or other files that are critical to the application. For example, an application may give an attacker the ability to overwrite a specified file or run with a configuration controlled by the attacker
References
IEAM-1538