Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Cleanup decompiler test fixtures and try to improve the test output / add a readable report #1724

Merged
merged 7 commits into from
Aug 5, 2022

Conversation

xTVaser
Copy link
Member

@xTVaser xTVaser commented Aug 4, 2022

Reports will showup in the wrong spot unfortunately due to an underlying github issue - dorny/test-reporter#67

@xTVaser xTVaser force-pushed the v/decomp-test-cleanup branch from 2a64225 to 263fc42 Compare August 4, 2022 23:03
@xTVaser xTVaser marked this pull request as ready for review August 5, 2022 00:23
@xTVaser xTVaser changed the title tests: Cleanup decompiler text fixtures and try to improve the test output / add a readable report tests: Cleanup decompiler test fixtures and try to improve the test output / add a readable report Aug 5, 2022
Copy link
Collaborator

@water111 water111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is definitely a cleaner way that what I was originally thinking (single fixture with jak1/jak2 functions)

@water111 water111 merged commit 8651179 into master Aug 5, 2022
@water111 water111 deleted the v/decomp-test-cleanup branch August 5, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants