[#4518] Add log entries for prefill to Submission #5092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaszig
commented
Feb 7, 2025
Comment on lines
-491
to
-512
| def appointment_update_start(appointment: AppointmentInfo, plugin): | ||
| _create_log( | ||
| appointment.submission, | ||
| "appointment_update_start", | ||
| plugin=plugin, | ||
| ) | ||
|
|
||
|
|
||
| def appointment_update_success(appointment: AppointmentInfo, plugin): | ||
| _create_log( | ||
| appointment.submission, | ||
| "appointment_update_success", | ||
| plugin=plugin, | ||
| ) | ||
|
|
||
|
|
||
| def appointment_update_failure(appointment: AppointmentInfo, plugin, error): | ||
| _create_log( | ||
| appointment.submission, | ||
| "appointment_update_failure", | ||
| plugin=plugin, | ||
| error=error, |
There was a problem hiding this comment.
Removed this since we do not support update in the new appointments flow (have to cancel first and create a new one).
Some AVG logs are needed in the submission admin inline logging so decided to return a queryset based on the included tags and not the other way around. This let us have events with multiple tags and choose which ones we need according to the context.
vaszig
force-pushed
the
feature/4518-add-log-entries-for-prefill-plugins-to-submissions
branch
from
ef91e13 to
9613293
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5092 +/- ##
==========================================
- Coverage 96.74% 96.74% -0.01%
==========================================
Files 771 771
Lines 26636 26631 -5
Branches 3467 3467
==========================================
- Hits 25770 25765 -5
+ Misses 605 604 -1
- Partials 261 262 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4518
Changes
Some AVG logs are needed in the submission admin inline logging so decided to return a queryset based on the included tags and not the other way around. This let us have events with multiple tags and choose which ones we need according to the context.
Checklist
Check off the items that are completed or not relevant.
Impact on features
Release management
I have updated the translations assets (you do NOT need to provide translations)
./bin/makemessages_js.sh./bin/compilemessages_js.shDockerfile/scripts
./binfolderCommit hygiene