Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing deprecated /location/get-street-name-and-city api endpoint #4878

Conversation

robinmolen
Copy link
Contributor

Part of #3283

Changes

The /api/v2/location/get-street-name-and-city endpoint has been removed, in favor of /api/v2/geo/address-autocomplete endpoint.
For the time being /api/v2/location/get-street-name-and-city will redirect to /api/v2/geo/address-autocomplete.

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

The /api/v2/location/get-street-name-and-city endpoint has been removed, in favor of /api/v2/geo/address-autocomplete endpoint.
For now, /api/v2/location/get-street-name-and-city will redirect to /api/v2/geo/address-autocomplete.
@robinmolen robinmolen force-pushed the task/3283-remove-location-get-street-name-and-city-endpoint branch from ae46928 to 55c7f3e Compare December 4, 2024 10:15
@robinmolen robinmolen requested review from vaszig and removed request for sergei-maertens December 4, 2024 10:15
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.61%. Comparing base (0bda3f3) to head (55c7f3e).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4878      +/-   ##
==========================================
- Coverage   96.61%   96.61%   -0.01%     
==========================================
  Files         751      751              
  Lines       25762    25761       -1     
  Branches     3413     3413              
==========================================
- Hits        24891    24890       -1     
  Misses        609      609              
  Partials      262      262              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@vaszig vaszig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@robinmolen robinmolen merged commit e4dd230 into master Dec 4, 2024
34 checks passed
@robinmolen robinmolen deleted the task/3283-remove-location-get-street-name-and-city-endpoint branch December 4, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants