Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to MSW 2 #4840

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Upgrade to MSW 2 #4840

merged 1 commit into from
Nov 25, 2024

Conversation

sergei-maertens
Copy link
Member

Depends on #4817 to be merged first

Changes

Upgraded MSW mock tool for jest/storybook so we get that out of the way asap.

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.61%. Comparing base (aff67a0) to head (4cf3252).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4840   +/-   ##
=======================================
  Coverage   96.61%   96.61%           
=======================================
  Files         751      751           
  Lines       25679    25679           
  Branches     3395     3395           
=======================================
  Hits        24809    24809           
  Misses        608      608           
  Partials      262      262           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Major version bump, so the mocks had to be updated too. This should
make upgrading Storybook easier in the future since we don't need to
pin MSW to 1.x
@sergei-maertens sergei-maertens marked this pull request as ready for review November 25, 2024 13:57
@sergei-maertens sergei-maertens merged commit 9e26c24 into master Nov 25, 2024
37 checks passed
@sergei-maertens sergei-maertens deleted the chore/upgrade-msw branch November 25, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant