Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#2632] fix recursion error #2968

Merged
merged 3 commits into from
Apr 6, 2023
Merged

[#2632] fix recursion error #2968

merged 3 commits into from
Apr 6, 2023

Conversation

pi-sigma
Copy link
Contributor

@pi-sigma pi-sigma commented Apr 5, 2023

Fixes #2632

  • Currently this patch not a real fix, it merely circumvents the RecursionError without addressing the root problem

@pi-sigma pi-sigma force-pushed the issue/2632-recursion-error branch from e67f6c1 to de518f0 Compare April 5, 2023 14:34
@codecov
Copy link

codecov bot commented Apr 5, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (1af9351) 94.25% compared to head (7532121) 94.25%.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2968   +/-   ##
=======================================
  Coverage   94.25%   94.25%           
=======================================
  Files         605      605           
  Lines       18585    18586    +1     
  Branches     2124     2125    +1     
=======================================
+ Hits        17518    17519    +1     
  Misses        775      775           
  Partials      292      292
Impacted Files Coverage Δ
...rc/openforms/submissions/models/submission_step.py 94.39% <100.00%> (+0.05%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pi-sigma pi-sigma force-pushed the issue/2632-recursion-error branch from de518f0 to 8532cde Compare April 6, 2023 13:49
@sergei-maertens sergei-maertens force-pushed the issue/2632-recursion-error branch from c721d6f to 7532121 Compare April 6, 2023 14:39
@sergei-maertens sergei-maertens marked this pull request as ready for review April 6, 2023 14:40
sergei-maertens
sergei-maertens approved these changes Apr 6, 2023
View reviewed changes
Copy link
Member

@sergei-maertens sergei-maertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked with Paul

@sergei-maertens sergei-maertens added the needs-backport Fix must be backported to stable release branch label Apr 6, 2023
@sergei-maertens sergei-maertens merged commit 453efbd into master Apr 6, 2023
@sergei-maertens sergei-maertens deleted the issue/2632-recursion-error branch April 6, 2023 15:05
sergei-maertens pushed a commit that referenced this pull request Apr 6, 2023
@pi-sigma @sergei-maertens
🩹 [#2632] -- work around recursion when deleting submission querysets
2dda0a9 
Backport-of: #2968
sergei-maertens pushed a commit that referenced this pull request Apr 6, 2023
@pi-sigma @sergei-maertens
🩹 [#2632] -- work around recursion when deleting submission querysets
c5144ed 
Backport-of: #2968
@sergei-maertens
Copy link
Member

Backports: 2dda0a9 and c5144ed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergei-maertens sergei-maertens sergei-maertens approved these changes

Assignees
No one assigned
Labels
needs-backport Fix must be backported to stable release branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Recursion error in periodic data removal
2 participants
@pi-sigma @sergei-maertens