Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2251] Fix date logic issue (attempt 2) #2383

Merged
merged 13 commits into from
Nov 24, 2022

Conversation

SilviaAmAm
Copy link
Contributor

@SilviaAmAm SilviaAmAm commented Nov 23, 2022

Fixes #2251

This is mostly a bandaid fix while we wait for #2324

Changes in JSON logic for this PR: maykinmedia/json-logic-py#10

This adds the variable today which was also requested here: #2357

@SilviaAmAm SilviaAmAm force-pushed the fix/2251-date-issues-attempt2 branch from a8e9e04 to 36d1be5 Compare November 23, 2022 11:15
@SilviaAmAm SilviaAmAm force-pushed the fix/2251-date-issues-attempt2 branch from 36d1be5 to 1b13a2e Compare November 23, 2022 13:29
@SilviaAmAm SilviaAmAm force-pushed the fix/2251-date-issues-attempt2 branch from 1e00a59 to 10fa348 Compare November 23, 2022 15:46
@codecov-commenter
Copy link

Codecov Report

Base: 93.53% // Head: 93.53% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (dcda0a9) compared to base (f8b1569).
Patch coverage: 86.66% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2383      +/-   ##
==========================================
- Coverage   93.53%   93.53%   -0.01%     
==========================================
  Files         651      651              
  Lines       20729    20742      +13     
  Branches     1960     1963       +3     
==========================================
+ Hits        19389    19400      +11     
- Misses       1023     1024       +1     
- Partials      317      318       +1     
Impacted Files Coverage Δ
src/openforms/formio/constants.py 100.00% <ø> (ø)
src/openforms/forms/tests/variables/test_model.py 100.00% <ø> (ø)
...ms/submissions/models/submission_value_variable.py 95.88% <71.42%> (-1.07%) ⬇️
src/openforms/variables/constants.py 100.00% <100.00%> (ø)
...rms/variables/static_variables/static_variables.py 100.00% <100.00%> (ø)
src/openforms/formio/utils.py 100.00% <0.00%> (ø)
src/openforms/formio/tests/assertions.py 100.00% <0.00%> (ø)
...c/openforms/forms/api/serializers/form_variable.py 100.00% <0.00%> (ø)
src/openforms/forms/models/form_variable.py 98.48% <0.00%> (+0.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sergei-maertens sergei-maertens merged commit f3ce945 into master Nov 24, 2022
@sergei-maertens sergei-maertens deleted the fix/2251-date-issues-attempt2 branch November 24, 2022 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logic with "now" variable not triggering with "bigger than" and "less than"
3 participants