Select process variables from defined components #1115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1115 +/- ##
==========================================
+ Coverage 89.03% 89.07% +0.04%
==========================================
Files 422 424 +2
Lines 11761 11815 +54
Branches 1084 1098 +14
==========================================
+ Hits 10471 10524 +53
Misses 1066 1066
- Partials 224 225 +1
Continue to review full report at Codecov.
|
sergei-maertens
force-pushed
the
feature/326-select-process-variables
branch
4 times, most recently
from
ec6ded8 to
160ccc3
Compare
SilviaAmAm
requested changes
Dec 24, 2021
src/openforms/js/components/admin/form_design/registrations/camunda/FormFields.js
Outdated
Show resolved
Hide resolved
src/openforms/js/components/admin/form_design/registrations/camunda/FormFields.js
Show resolved
Hide resolved
sergei-maertens
force-pushed
the
feature/326-select-process-variables
branch
3 times, most recently
from
8da0088 to
4a39955
Compare
|
@joeribekker backend is ready for review |
This is the simple variant.
Split up in more re-usable components to keep consistent styling in other places.
By now half of the tabs need access to all the defined components, so it makes more sense to provide that as context to the entire tab list.
sergei-maertens
force-pushed
the
feature/326-select-process-variables
branch
from
4a39955 to
67df43a
Compare
joeribekker
approved these changes
Dec 29, 2021
|
|
||
| class CamundaApp(AppConfig): | ||
| name = "openforms.registrations.contrib.camunda" | ||
| label = "registrations_camunda" | ||
| verbose_name = _("Camunda registration plugin") | ||
|
|
||
| def ready(self): | ||
| patch_django_camunda() |
There was a problem hiding this comment.
Why not update django_camunda? This doesn't seem OF specific?
There was a problem hiding this comment.
as discussed during standup - mapping a Python Decimal with fixed precision to a Java Double (with floating point precision errors) is probably not guaranteed to be correct, but a best effort we can do.
At some point we'll probably include it in django-camunda with a disclaimer or a setting to enable/override it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #326
First phase - simple process variable mapping.
Changes