Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attachments in a repeating group are not processed in the JSON dump registration backend #5065

Closed
viktorvanwijk opened this issue Jan 31, 2025 · 0 comments · Fixed by #5081
Closed

Attachments in a repeating group are not processed in the JSON dump registration backend #5065

viktorvanwijk opened this issue Jan 31, 2025 · 0 comments · Fixed by #5081
Assignees
@viktorvanwijk
Labels
owner: venlo topic: registration
Milestone
Release 3.1.0

Comments

@viktorvanwijk
Copy link
Contributor

For file components, the content of attachments are encoded using base64, and added to the data to be sent. A repeating group can also contain a file component, which is currently not processed. It should be.
@viktorvanwijk viktorvanwijk added this to the Release 3.1.0 milestone Jan 31, 2025
@viktorvanwijk viktorvanwijk moved this from Todo to In Progress in Development Feb 3, 2025
viktorvanwijk added a commit that referenced this issue Feb 3, 2025
@viktorvanwijk
🚧 [#5065] WIP
ecb1099
viktorvanwijk added a commit that referenced this issue Feb 4, 2025
@viktorvanwijk
🐛 [#5065] Add processing of edit grid component in JSON dump plugin
c7d7f93 
The edit grid component was not processed, meaning components (File, Radio, Select, and SelectBoxes) inside the edit grid component were not updated properly. They are now
viktorvanwijk added a commit that referenced this issue Feb 4, 2025
@viktorvanwijk
✅ [#5065] Add tests
5644149 
* Add test for a (multiple) file component inside an edit grid component. Ensures the attachments are properly encoded.
@viktorvanwijk viktorvanwijk mentioned this issue Feb 5, 2025
Merged
10 tasks
viktorvanwijk added a commit that referenced this issue Feb 5, 2025
@viktorvanwijk
🐛 [#5065] Add processing of edit grid component in JSON dump plugin
74be28a 
The edit grid component was not processed, meaning components (File, Radio, Select, and SelectBoxes) inside the edit grid component were not updated properly. They are now
viktorvanwijk added a commit that referenced this issue Feb 5, 2025
@viktorvanwijk
✅ [#5065] Add tests
22e9720 
* Add test for a (multiple) file component inside an edit grid component. Ensures the attachments are properly encoded.
* Add test for components with another form variable as a data source inside an edit grid component. Ensures the options of the radio, select, and selectboxes components are properly updated.
@viktorvanwijk viktorvanwijk moved this from In Progress to Implemented in Development Feb 5, 2025
viktorvanwijk added a commit that referenced this issue Feb 6, 2025
@viktorvanwijk
🐛 [#5065] Add processing of edit grid component in JSON dump plugin
d9e0fa2 
The edit grid component was not processed, meaning components (File, Radio, Select, and SelectBoxes) inside the edit grid component were not updated properly. They are now
viktorvanwijk added a commit that referenced this issue Feb 6, 2025
@viktorvanwijk
✅ [#5065] Add tests
2c638d2 
* Add test for a (multiple) file component inside an edit grid component. Ensures the attachments are properly encoded.
* Add test for components with another form variable as a data source inside an edit grid component. Ensures the options of the radio, select, and selectboxes components are properly updated.
@github-project-automation github-project-automation bot moved this from Implemented to Done in Development Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@viktorvanwijk viktorvanwijk

Labels
owner: venlo topic: registration
Projects
Development
Status: Done
Milestone
Release 3.1.0
Development

Successfully merging a pull request may close this issue.

Process edit grid components in the json dump registration backend open-formulieren/open-forms
1 participant
@viktorvanwijk