Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal close button on dark mode #4949

Closed
robinmolen opened this issue Dec 18, 2024 · 0 comments · Fixed by #4950
Closed

Modal close button on dark mode #4949

robinmolen opened this issue Dec 18, 2024 · 0 comments · Fixed by #4950
Assignees
@robinmolen
Labels
needs-backport Fix must be backported to stable release branch

Comments

@robinmolen
Copy link
Contributor

Product versie / Product version

3.0.0-alpha.0

Customer reference

No response

Omschrijf het probleem / Describe the bug

When using the admin/backend on dark mode, the close buttons of modals are barely/not visible:

Screenshot 2024-12-18 at 11 03 34

^ Close button is on the top-right. Can you see it ;)

Stappen om te reproduceren / Steps to reproduce

  1. Go to admin
  2. Enter dark mode
  3. Open backend registration config modal (on Email plug, for example)
  4. ...
  5. Profit

Verwacht gedrag / Expected behavior

The modal button should change color based on light/dark mode of the admin application

Screen resolution

None

Device

None

OS

None

Browser

No response
@robinmolen robinmolen added the bug label Dec 18, 2024
@robinmolen robinmolen self-assigned this Dec 18, 2024
@robinmolen robinmolen moved this from Todo to In Progress in Development Dec 18, 2024
@robinmolen robinmolen added the needs-backport Fix must be backported to stable release branch label Dec 18, 2024
robinmolen added a commit that referenced this issue Dec 18, 2024
@robinmolen
💄 [#4949] Modal close button on dark mode
1456106 
The modal close button changes color based on the light/dark mode of the page.

In addition, focus now increases the button opacity, making it more user-friendly
@robinmolen robinmolen mentioned this issue Dec 18, 2024
Merged
10 tasks
@robinmolen robinmolen moved this from In Progress to Implemented in Development Dec 18, 2024
robinmolen added a commit that referenced this issue Dec 18, 2024
@robinmolen
💄 [#4949] Modal close button on dark mode
53dff87 
The modal close button changes color based on the light/dark mode of the page.

In addition, focus now increases the button opacity, making it more user-friendly
@github-project-automation github-project-automation bot moved this from Implemented to Done in Development Dec 18, 2024
sergei-maertens pushed a commit that referenced this issue Dec 18, 2024
@robinmolen @sergei-maertens
💄 [#4949] Modal close button on dark mode
1d81810 
The modal close button changes color based on the light/dark mode of the page.

In addition, focus now increases the button opacity, making it more user-friendly

Backport-of: #4950
sergei-maertens pushed a commit that referenced this issue Dec 18, 2024
@robinmolen @sergei-maertens
💄 [#4949] Modal close button on dark mode
613514c 
The modal close button changes color based on the light/dark mode of the page.

In addition, focus now increases the button opacity, making it more user-friendly

Backport-of: #4950
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robinmolen robinmolen

Labels
needs-backport Fix must be backported to stable release branch
Projects
Development
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Modal close button on dark mode open-formulieren/open-forms
1 participant
@robinmolen