Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Familymembers component should not crash the form if no BSN is known #1302

Closed
joeribekker opened this issue Feb 3, 2022 · 2 comments · Fixed by #2421
Closed

Familymembers component should not crash the form if no BSN is known #1302

joeribekker opened this issue Feb 3, 2022 · 2 comments · Fixed by #2421
Assignees
@sergei-maertens
Labels
owner: den-haag
Milestone
Release 2.1.0

Comments

@joeribekker
Copy link
Contributor

In #1275 this was solved in the form design by showing a warning if no autg option was selected, however, if for some reason there is still no BSN, the form does not need to crash.

Instead, we can show an empty component, or if possible a user friendly error message "Selecting family members is currently unavailable." or so.
@joeribekker joeribekker added the bug label Feb 3, 2022
@sergei-maertens
Copy link
Member

Also requires the #1068 to be finished for the dynamic plugins. We've come a very long way with variables to finally finish that.

@sergei-maertens sergei-maertens self-assigned this Oct 7, 2022
@sergei-maertens
Copy link
Member

Depends on #2388 to be finished first

sergei-maertens added a commit that referenced this issue Dec 1, 2022
@sergei-maertens
🧪 [#1302] -- added regression test for crash
fa5a45d
sergei-maertens added a commit that referenced this issue Dec 1, 2022
@sergei-maertens
🐛 [#1302] -- Change component into content with warning when no bsn i…
a673284 
…s available

Instead of changing the component into a selectboxes component or
crashing hard when no submission bsn is available, the error situation
is detected and turned into a warning situation via content component
type instead.
@sergei-maertens sergei-maertens mentioned this issue Dec 1, 2022
Merged
@sergei-maertens sergei-maertens moved this to Todo in Development Dec 8, 2022
@sergei-maertens sergei-maertens moved this from Todo to Done in Development Dec 8, 2022
@sergei-maertens sergei-maertens added this to the Release 2.1.0 milestone Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sergei-maertens sergei-maertens

Labels
owner: den-haag
Projects
Development
Archived in project
Milestone
Release 2.1.0
Development

Successfully merging a pull request may close this issue.

Prevent hard crash for familymembers component without bsn open-formulieren/open-forms
2 participants
@joeribekker @sergei-maertens