Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React Form editor allows editing when user does not have write access #1000

Closed
6 tasks done
stevenbal opened this issue Nov 26, 2021 · 0 comments · Fixed by #1137
Closed
6 tasks done

React Form editor allows editing when user does not have write access #1000

stevenbal opened this issue Nov 26, 2021 · 0 comments · Fixed by #1137
Assignees
Milestone

Comments

@stevenbal
Copy link
Contributor

stevenbal commented Nov 26, 2021

If React is enabled for the Form editor page via the General configuration, the Form admin page (/admin/forms/form/<form_id>) is editable for any user that is staff (even if these users do not have write permission)

Tested locally with a user that is staff and only has read permissions
image

Tasks

  • Add permission class(es) to API endpoints (form app related)
  • Write access (put/patch/post/delete) is ONLY given to staff users that have forms.change_form permission
  • Read access (get) to everything give to staff users that have form.change_form permission
  • Read access (get) to forms.form_LIST given to non-staff users that have forms.view_form permission
  • Read access (get) to forms.form_DETAIL given to anonymous users
  • Leave other app permissions as they are
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants