Skip to content

Commit

Permalink
Merge pull request #5078 from open-formulieren/fix/5077-improve-perfo…
Browse files Browse the repository at this point in the history
…rmance-in-logic-rules-list-qs

[#5077] Improve performance in loading logic rules in admin
  • Loading branch information
sergei-maertens authored Feb 6, 2025
2 parents 4c86bcb + 7a56bce commit 9894ae6
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions src/openforms/forms/api/viewsets.py
Original file line number Diff line number Diff line change
Expand Up @@ -531,7 +531,7 @@ def variables_list(self, request, *args, **kwargs):
form = self.get_object()
filterset = FormVariableFilter(
request.GET,
queryset=form.formvariable_set.select_related("form", "form_definition"),
queryset=form.formvariable_set.prefetch_related("form", "form_definition"),
)

serializer = FormVariableSerializer(
Expand Down Expand Up @@ -590,7 +590,10 @@ def logic_rules_bulk_update(self, request, *args, **kwargs):
@logic_rules_bulk_update.mapping.get
def logic_rules_list(self, request, *args, **kwargs):
form = self.get_object()
logic_rules = form.formlogic_set.all()

logic_rules = form.formlogic_set.prefetch_related(
"form", "trigger_from_step__form"
)

serializer = FormLogicSerializer(
instance=logic_rules,
Expand Down

0 comments on commit 9894ae6

Please sign in to comment.