fix: named client events #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
toddbaert
commented
Jun 29, 2023
toddbaert
commented
- fixed issues where named client wouldnt get events from a default provider
toddbaert
force-pushed
the
fix/default-provider-named-client
branch
from
28269a5 to
72717b9
Compare
|
@lukas-reining I think this is a bug. I found it doing some integration testing. The new tests failed without my change. We still need to transfer the "unbound" emitters when the default provider is changed, I think. Please take a look and make sure the solution makes sense to you. If you think we need additional changes, feel free to push more to this branch. I did this pretty quickly to prove out the problem, so there's possibly things that can be improved. |
toddbaert
force-pushed
the
fix/default-provider-named-client
branch
2 times, most recently
from
8990897 to
cda86f5
Compare
* fixed issues where named client wouldnt get events from a default provider Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
toddbaert
force-pushed
the
fix/default-provider-named-client
branch
from
cda86f5 to
c26b421
Compare
Signed-off-by: Lukas Reining <lukas.reining@codecentric.de>
There was a problem hiding this comment.
Oh yes that is a problem.
Your solution looks good and makes sense.
Just refactored a bit and used getAndCacheEventEmitterForClient when getting the emitters.
What do you think @toddbaert?
lukas-reining
approved these changes
Jun 30, 2023
|
@lukas-reining that makes sense, and I very much like your refactors! |
This was referenced Jul 4, 2023
toddbaert
pushed a commit
that referenced
this pull request
Jul 4, 2023
🤖 I have created a release *beep* *boop* --- ## [0.0.6](shared-v0.0.5...shared-v0.0.6) (2023-07-04) ### Bug Fixes * named client events ([#472](#472)) ([fb69b9d](fb69b9d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
toddbaert
pushed a commit
that referenced
this pull request
Jul 4, 2023
🤖 I have created a release *beep* *boop* --- ## [0.3.6-experimental](web-sdk-v0.3.5-experimental...web-sdk-v0.3.6-experimental) (2023-07-04) ### Bug Fixes * named client events ([#472](#472)) ([fb69b9d](fb69b9d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
toddbaert
added a commit
that referenced
this pull request
Jul 4, 2023
🤖 I have created a release *beep* *boop* --- ## [1.3.2](js-sdk-v1.3.1...js-sdk-v1.3.2) (2023-07-04) ### Bug Fixes * named client events ([#472](#472)) ([fb69b9d](fb69b9d)) * various event handler issues ([1dd1e17](1dd1e17)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: Todd Baert <todd.baert@dynatrace.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Todd Baert <todd.baert@dynatrace.com>
This was referenced Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.