Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update min SDK version #1152

Merged
merged 2 commits into from
Jan 13, 2025
Merged

chore: update min SDK version #1152

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0db3c76
chore: update min SDK version
toddbaert Jan 10, 2025
2e48388
fixup: checkstyle issue
aepfli Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hooks/open-telemetry/src/main/java/dev/openfeature/contrib/hooks/otel/MetricsHook.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ public void error(HookContext ctx, Exception error, Map hints) {
}

@Override
public void finallyAfter(HookContext ctx, Map hints) {
public void finallyAfter(HookContext ctx, FlagEvaluationDetails details, Map hints) {
activeFlagEvaluationsCounter.add(-1, Attributes.of(flagKeyAttributeKey, ctx.getFlagKey()));
}

Expand Down
2 changes: 1 addition & 1 deletion hooks/open-telemetry/src/test/java/dev/openfeature/contrib/hooks/otel/MetricsHookTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ public void finally_stage_validation() {
final MetricsHook metricHook = new MetricsHook(telemetryExtension.getOpenTelemetry());

// when
metricHook.finallyAfter(commonHookContext, null);
metricHook.finallyAfter(commonHookContext, null, null);
List<MetricData> metrics = telemetryExtension.getMetrics();

// then
Expand Down
4 changes: 2 additions & 2 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,8 @@
<!-- this can be overriden in child POMs to support specific SDK requirements -->
<groupId>dev.openfeature</groupId>
<artifactId>sdk</artifactId>
<!-- 1.12 <= v < 2.0 -->
<version>[1.12,2.0)</version>
<!-- 1.14 <= v < 2.0 (excluding 2.0 pre-releases)-->
<version>[1.14,1.99999)</version>
aepfli marked this conversation as resolved.
Show resolved Hide resolved
<!-- use the version provided at runtime -->
<scope>provided</scope>
</dependency>
Expand Down
1 change: 1 addition & 0 deletions ...main/java/dev/openfeature/contrib/providers/flagd/resolver/process/InProcessResolver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
import dev.openfeature.sdk.Value;
import dev.openfeature.sdk.exceptions.ParseError;
import dev.openfeature.sdk.exceptions.TypeMismatchError;
import java.util.Map;
import java.util.function.Consumer;
import java.util.function.Supplier;
import lombok.extern.slf4j.Slf4j;
Expand Down
Loading