chore: update failing tests (#732)

Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
open-feature · Apr 1, 2024 · e1eaf4e · e1eaf4e
1 parent b5dc2eb
commit e1eaf4e
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 14 deletions.
diff --git a/...gcat/src/test/java/dev/openfeature/contrib/providers/configcat/ConfigCatProviderTest.java b/...gcat/src/test/java/dev/openfeature/contrib/providers/configcat/ConfigCatProviderTest.java
@@ -218,6 +218,7 @@ void contextTransformTest() {
         String country = "someCountry";
         String customPropertyValue = "customProperty_value";
         String customPropertyKey = "customProperty";
+        String targetingKeyKey = "targetingKey";
 
         MutableContext evaluationContext = new MutableContext();
         evaluationContext.setTargetingKey(userId);
@@ -227,7 +228,7 @@ void contextTransformTest() {
 
         HashMap<String, Object > customMap = new HashMap<>();
         customMap.put(customPropertyKey, customPropertyValue);
-        customMap.put("targetingKey", userId);
+        customMap.put(targetingKeyKey, userId);
         User expectedUser = User.newBuilder().email(email).country(country).custom(customMap).build(userId);
         User transformedUser = ContextTransformer.transform(evaluationContext);
 

diff --git a/.../statsig/src/test/java/dev/openfeature/contrib/providers/statsig/StatsigProviderTest.java b/.../statsig/src/test/java/dev/openfeature/contrib/providers/statsig/StatsigProviderTest.java
@@ -43,19 +43,19 @@
  */
 class StatsigProviderTest {
 
-    public static final String FLAG_NAME = "enabledFeature";
-    public static final String CONFIG_FLAG_NAME = "alias";
-    public static final String LAYER_FLAG_NAME = "alias";
-    public static final String CONFIG_FLAG_VALUE = "test";
-    public static final String INT_FLAG_NAME = "revision";
-    public static final String LAYER_INT_FLAG_NAME = "revision";
-    public static final Integer INT_FLAG_VALUE = 5;
-    public static final String DOUBLE_FLAG_NAME = "price";
-    public static final String LAYER_DOUBLE_FLAG_NAME = "price";
-    public static final Double DOUBLE_FLAG_VALUE = 3.14;
-    public static final String USERS_FLAG_NAME = "userIdMatching";
-    public static final String PROPERTIES_FLAG_NAME = "emailMatching";
-    public static final String TARGETING_KEY = "user1";
+    private static final String FLAG_NAME = "enabledFeature";
+    private static final String CONFIG_FLAG_NAME = "alias";
+    private static final String LAYER_FLAG_NAME = "alias";
+    private static final String CONFIG_FLAG_VALUE = "test";
+    private static final String INT_FLAG_NAME = "revision";
+    private static final String LAYER_INT_FLAG_NAME = "revision";
+    private static final Integer INT_FLAG_VALUE = 5;
+    private static final String DOUBLE_FLAG_NAME = "price";
+    private static final String LAYER_DOUBLE_FLAG_NAME = "price";
+    private static final Double DOUBLE_FLAG_VALUE = 3.14;
+    private static final String USERS_FLAG_NAME = "userIdMatching";
+    private static final String PROPERTIES_FLAG_NAME = "emailMatching";
+    private static final String TARGETING_KEY = "user1";
     private static StatsigProvider statsigProvider;
     private static Client client;