Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to go 1.20 #891

Merged
merged 1 commit into from
Sep 7, 2023
Merged

chore: upgrade to go 1.20 #891

merged 1 commit into from
Sep 7, 2023

Conversation

craigpastro
Copy link
Member

This PR

  • Upgrade to Go 1.20. Go 1.21 is out so Go 1.20 is the last officially supported version.
  • Run go mod tidy in subprojects
  • Unpins golang-lint that was pinned in chore: pin golangci-lint #849.

Issue #850 says "evaluate" upgrade to 1.20. Anything in particular to check?

Related Issues

Fixes #850.
Related #849.

Notes

Follow-up Tasks

How to test

Signed-off-by: Craig Pastro <pastro.craig@gmail.com>
@craigpastro craigpastro requested a review from a team as a code owner September 5, 2023 20:16
@netlify
Copy link

netlify bot commented Sep 5, 2023

Deploy Preview for polite-licorice-3db33c ready!

Name Link
🔨 Latest commit 6076d86
🔍 Latest deploy log https://app.netlify.com/sites/polite-licorice-3db33c/deploys/64f78ca7a694b2000707692b
😎 Deploy Preview https://deploy-preview-891--polite-licorice-3db33c.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

)

func init() {
rand.Seed(time.Now().UnixNano())
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessary in Go 1.20 and, in fact, rand.Seed is deprecated.

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #891 (6076d86) into main (fd56932) will decrease coverage by 0.22%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #891      +/-   ##
==========================================
- Coverage   72.94%   72.73%   -0.22%     
==========================================
  Files          28       28              
  Lines        2857     2857              
==========================================
- Hits         2084     2078       -6     
- Misses        679      683       +4     
- Partials       94       96       +2     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@toddbaert
Copy link
Member

Issue #850 says "evaluate" upgrade to 1.20. Anything in particular to check?

No - I just didn't want to make it a "needs-to-be-done-now" thing if for some reason there was a challenge.

Copy link
Member

@toddbaert toddbaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@toddbaert toddbaert merged commit 977167f into open-feature:main Sep 7, 2023
14 of 15 checks passed
@craigpastro craigpastro deleted the go-1.20 branch September 7, 2023 19:05
@github-actions github-actions bot mentioned this pull request Sep 7, 2023
Kavindu-Dodan pushed a commit that referenced this pull request Sep 8, 2023
🤖 I have created a release *beep* *boop*
---


<details><summary>flagd: 0.6.5</summary>

##
[0.6.5](flagd/v0.6.4...flagd/v0.6.5)
(2023-09-08)


### 🐛 Bug Fixes

* **deps:** update module github.com/open-feature/flagd/core to v0.6.4
([#880](#880))
([ebb543d](ebb543d))
* **deps:** update opentelemetry-go monorepo
([#868](#868))
([d48317f](d48317f))


### 🧹 Chore

* disable caching on integration tests
([#899](#899))
([16dd21e](16dd21e))
* upgrade to go 1.20
([#891](#891))
([977167f](977167f))
</details>

<details><summary>flagd-proxy: 0.2.10</summary>

##
[0.2.10](flagd-proxy/v0.2.9...flagd-proxy/v0.2.10)
(2023-09-08)


### 🐛 Bug Fixes

* **deps:** update module github.com/open-feature/flagd/core to v0.6.4
([#880](#880))
([ebb543d](ebb543d))
* **deps:** update opentelemetry-go monorepo
([#868](#868))
([d48317f](d48317f))


### 🧹 Chore

* upgrade to go 1.20
([#891](#891))
([977167f](977167f))
</details>

<details><summary>core: 0.6.5</summary>

##
[0.6.5](core/v0.6.4...core/v0.6.5)
(2023-09-08)


### 🐛 Bug Fixes

* **deps:** update module github.com/rs/cors to v1.10.0
([#893](#893))
([fe61fbe](fe61fbe))
* **deps:** update module golang.org/x/crypto to v0.13.0
([#888](#888))
([1a9037a](1a9037a))
* **deps:** update module golang.org/x/net to v0.15.0
([#889](#889))
([233d976](233d976))
* **deps:** update module google.golang.org/grpc to v1.58.0
([#896](#896))
([853b76d](853b76d))
* **deps:** update module sigs.k8s.io/controller-runtime to v0.16.1
([#882](#882))
([ca3d85a](ca3d85a))
* **deps:** update opentelemetry-go monorepo
([#868](#868))
([d48317f](d48317f))


### 🧹 Chore

* upgrade to go 1.20
([#891](#891))
([977167f](977167f))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Evaluate upgrade to go 1.20 or 1.21
2 participants