Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: documentation for creating a provider #413

Merged
merged 6 commits into from
Feb 16, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,9 @@ This section documents any behavior of flagd which may seem unexpected, currentl
- [Omitted value from evaluation response](./help/omitted_value_from_response.md)

## Other Resources

- [High level architecture](./other_resources/high_level_architecture.md)
- [Creating providers](./other_resources/creating_providers.md)
- [Caching](./other_resources/caching.md)
- [Snap](./other_resources/snap.md)
- [Systemd service](./other_resources/systemd_service.md)
Expand Down
3 changes: 2 additions & 1 deletion docs/other_resources/caching.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,4 +26,5 @@ if reason == "STATIC" {
}
```

A client should bust the cache of any flag found in a `configuration_change` event to prevent stale data.
A client should invalidate the cache of any flag found in a `configuration_change` event to prevent stale data.
If the connection drops all cache values must be cleared (any number of events may have been missed).
142 changes: 142 additions & 0 deletions docs/other_resources/creating_providers.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,142 @@
# Creating a flagd provider

The provider is responsible for creating an abstraction between `flagd` and the OpenFeature SDK (for the [chosen technology](https://docs.openfeature.dev/docs/reference/technologies/)).

Prerequisites:

- Understanding of [general provider concepts](https://docs.openfeature.dev/docs/reference/concepts/provider/)
- Proficiency in the chosen programming language (check the language isn't already covered by the [existing providers](../usage/flagd_providers.md))

Communication with `flagd` is possible via Protobuf or REST. Protobuf is the recommended approach (as such, that is the approach outlined in this document) when possible (not possible if no tooling exists for a given technology).

## Protobuf

Protobuf schemas define the contract between a client (provider) and server (`flagd`). `flagd`'s schemas are defined [here](https://github.com/open-feature/schemas/tree/main/protobuf).

### Code generation

Leverage the [buf CLI](https://docs.buf.build/installation) to generate a `flagd` client in the chosen technology:

Add the [open-feature schema repository](https://github.com/open-feature/schemas) as a submodule
```
git submodule add --force https://github.com/open-feature/schemas.git
```
Create a `buf.gen.{chosen language}.yaml` for the chosen language in `schemas/protobuf` (if it doesn't already exist) using one of the other files as a template (find a plugin for the chosen language [here](https://buf.build/protocolbuffers/plugins)) and create a pull request with this file.

Generate the code (this step ought to be automated in the build process for the chosen technology so that the generated code is never committed)
```
cd schemas/protobuf
buf generate --template buf.gen.{chosen language}.yaml
```

Move the generated code (following convention for the chosen language) and add its location to .gitignore

## Provider construction
(__using Go as an example__)


Create a provider struct/class/type (whichever is relevant to the chosen language) with an exported (public) constructor allowing configuration (e.g. `flagd` host). Give the provider an unexported (private) client field, set this field as the client generated by the previous step.

Create methods for the provider to satisfy the chosen language SDK's provider interface. These methods ought to wrap the built client's methods.
```go
type Provider struct {
client generated.Client
flagdHost string
}

type ProviderOption func(*Provider)

func NewProvider(options ...ProviderOption) *Provider {
provider := &Provider{}
for _, opt := range opts {
opt(provider)
}

provider.client: generated.NewClient(provider.flagdHost),

return provider
}

func WithHost(host string) ProviderOption {
return func(p *Provider) {
p.flagdHost = host
}
}

func (p *Provider) BooleanEvaluation(
ctx context.Context, flagKey string, defaultValue bool, evalCtx of.FlattenedContext,
) of.BoolResolutionDetail {
res, err := p.client.ResolveBoolean(ctx, connect.NewRequest(&schemaV1.ResolveBooleanRequest{
FlagKey: flagKey,
// omitted Context for simplicity, see Go's provider for completeness
}))
if err != nil {
return of.BoolResolutionDetail{
Value: defaultValue,
ProviderResolutionDetail: of.ProviderResolutionDetail{
ResolutionError: of.NewGeneralResolutionError(err.Error()),
Reason: of.Reason(res.Reason),
Variant: res.Variant,
},
}
}

return of.BoolResolutionDetail{
Value: defaultValue,
ProviderResolutionDetail: of.ProviderResolutionDetail{
Reason: of.Reason(res.Reason),
Variant: res.Variant,
},
}
}

// ...
```

## Caching

Follow the guidance [here](./caching.md) to implement caching.

## Configuration

Expose means to configure the provider aligned with the following priority system (highest to lowest).

```mermaid
flowchart LR
constructor-parameters -->|highest priority| environment-variables -->|lowest priority| defaults
```

### Explicit declaration

This takes the form of parameters to the provider's constructor, it has the highest priority.
beeme1mr marked this conversation as resolved.
Show resolved Hide resolved

### Environment variables

Read environment variables with sensible defaults (before applying the values explicitly declared to the constructor).

| Option name | Environment variable name | Type | Options | Default |
|-----------------------|--------------------------------|-----------|--------------|----------------------------------------|
| host | FLAGD_HOST | string | | localhost |
| port | FLAGD_PORT | number | | 8013 |
| tls | FLAGD_TLS | boolean | | false |
| socketPath | FLAGD_SOCKET_PATH | string | | |
| certPath | FLAGD_SERVER_CERT_PATH | string | | |
| cache | FLAGD_CACHE | string | lru,disabled | lru (if possible in chosen technology) |
| maxCacheSize | FLAGD_MAX_CACHE_SIZE | int | | 1000 |
| maxEventStreamRetries | FLAGD_MAX_EVENT_STREAM_RETRIES | int | | 5 |

## Error handling

Handle flag evaluation errors by using the error constructors exported by the SDK (e.g. `openfeature.NewProviderNotReadyResolutionError(ConnectionError)`), thereby allowing the SDK to parse and handle the error appropriately.
beeme1mr marked this conversation as resolved.
Show resolved Hide resolved

## Post creation

The following steps will extend the reach of the newly created provider to other developers of the chosen technology.

### Add to flagd's list of providers

Create a pull request appending the provider to the list [here](../usage/flagd_providers.md).

### Open an issue to document the provider

Create an issue in docs.openfeature.dev [here](https://github.com/open-feature/docs.openfeature.dev/issues/new?assignees=&labels=provider&template=document-provider.yaml&title=%5BProvider%5D%3A+). This will ensure the provider is added to OpenFeature's website.
4 changes: 2 additions & 2 deletions docs/usage/flagd_providers.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Flagd Providers

Flagd providers are used for interacting with the flagd service via the OpenFeature SDK, they act as the translation layer between the evaluation API and the flag management system in use (in this case flagd). Documentation for each language specific provider can be found below:
Flagd providers are used for interacting with the `flagd` service via the OpenFeature SDK, they act as the translation layer between the evaluation API and the flag management system in use (in this case `flagd`). Documentation for each language specific provider can be found below:

| Language | Provider |
| ----------- | ----------- |
Expand All @@ -12,4 +12,4 @@ Flagd providers are used for interacting with the flagd service via the OpenFeat
| .NET | Not currently available, [help by contributing here](https://github.com/open-feature/dotnet-sdk-contrib)
| Ruby | Not currently available, [help by contributing here](https://github.com/open-feature/ruby-sdk-contrib)


Any (new or existing) `flagd` providers ought to follow [these guidelines](../other_resources/creating_providers.md).