feat!: start command flag refactor #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Milligan <james@omnant.co.uk>
|
This makes sense to me. I think watching multiple k8s-resources is sort of a must have, and this seems like a clean way to do it. I'll test this out a bit, but I like the approach. |
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
james-milligan
requested review from
skyerus,
toddbaert,
beeme1mr and
Kavindu-Dodan
Signed-off-by: James Milligan <james@omnant.co.uk>
toddbaert
reviewed
Nov 24, 2022
toddbaert
reviewed
Nov 24, 2022
|
Tested this locally as well and everything works as expected, including updates, merging and warnings about duplicate flags across sources.. The experience is definitely improved. I know some changes based on the OFO review are incoming so I'll wait to approve. |
Signed-off-by: James Milligan <james@omnant.co.uk>
Co-authored-by: Todd Baert <toddbaert@gmail.com> Signed-off-by: James Milligan <75740990+james-milligan@users.noreply.github.com>
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
skyerus
reviewed
Nov 29, 2022
skyerus
reviewed
Nov 29, 2022
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
Signed-off-by: James Milligan <james@omnant.co.uk>
skyerus
approved these changes
Nov 29, 2022
Signed-off-by: James Milligan <james@omnant.co.uk>
I agree with @skyerus that this is breaking, since it breaks the command line. I think you should add a EDIT: in fact I've done so, and approved. |
james-milligan
changed the title
toddbaert
approved these changes
Nov 29, 2022
AlexsJones
approved these changes
Nov 30, 2022
Signed-off-by: James Milligan <james@omnant.co.uk>
…ligan/flagd into sync-provider-refactor
AlexsJones
pushed a commit
that referenced
this pull request
Dec 5, 2022
🤖 I have created a release *beep* *boop* --- ## [0.2.7](v0.2.5...v0.2.7) (2022-12-02) ### ⚠ BREAKING CHANGES * start command flag refactor ([#222](#222)) ### Features * enable request logging via the --debug flag ([#226](#226)) ([11954b5](11954b5)) * Resurrected the STATIC flag reason. Documented the caching strategy. ([#224](#224)) ([5830592](5830592)) * snap ([#211](#211)) ([c619844](c619844)) * start command flag refactor ([#222](#222)) ([14474cc](14474cc)) ### Miscellaneous Chores * release v0.2.6 ([93cfb78](93cfb78)) * release v0.2.7 ([4a9f6df](4a9f6df)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
beeme1mr
added a commit
to open-feature/playground
that referenced
this pull request
Jan 5, 2023
Addresses changes introduced by flagd 0.2.7 described [here](open-feature/flagd#222). Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: James Milligan james@omnant.co.uk
Corresponding OFO changes here
This PR
--sync-provider--uriflags can be passed indicating the use of different existingsync-providertypes, all of which will worksync-provider;http(s)://will be passed to the http sync,file://will be passed to the file path sync and the Kubernetes sync uses the following patterncore.openfeature.dev/{namespace}/{name}, this will also allow for the Kubernetes sync to watch multipleFeatureFlagConfigurationsfrom different namespaces.--sync-providerflag is passed as an argument./flagd start --uri file://etc/flagd/end-to-end.json --uri core.openfeature.dev/test/end-to-end-2Related Issues
open-feature/open-feature-operator#251
Notes
Follow-up Tasks
How to test