feat: s3 support for the blob sync #1449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
✅ Deploy Preview for polite-licorice-3db33c canceled.
|
beeme1mr
reviewed
Nov 21, 2024
beeme1mr
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
I've manually tested this and it works as expected. Thanks @djosephsen!
toddbaert
approved these changes
Dec 11, 2024
Signed-off-by: Dave Josephsen <dave.josephsen@gmail.com>
toddbaert
force-pushed
the
dj/s3_sync
branch
from
05888fc to
9b5e8c7
Compare
|
@djosephsen I fixed some go.sum merge conflicts with main and force pushed back to your branch - no other changes. I hope you don't mind. Will merge when the CI passes. cc @beeme1mr |
|
this fell off my radar thanks, im at a corp onsite this week but I should be able to get back on this next week (for the docs update) |
Merged
toddbaert
pushed a commit
that referenced
this pull request
Dec 18, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>flagd: 0.11.5</summary> ## [0.11.5](flagd/v0.11.4...flagd/v0.11.5) (2024-12-17) ### 🐛 Bug Fixes * **deps:** update module buf.build/gen/go/open-feature/flagd/protocolbuffers/go to v1.35.2-20240906125204-0a6a901b42e8.1 ([#1451](#1451)) ([8c6d91d](8c6d91d)) * **deps:** update module buf.build/gen/go/open-feature/flagd/protocolbuffers/go to v1.36.0-20240906125204-0a6a901b42e8.1 ([#1475](#1475)) ([0b11c6c](0b11c6c)) * **deps:** update module github.com/open-feature/flagd/core to v0.10.4 ([#1433](#1433)) ([d33c7a5](d33c7a5)) * **deps:** update module github.com/stretchr/testify to v1.10.0 ([#1455](#1455)) ([8c843df](8c843df)) * **deps:** update module golang.org/x/net to v0.31.0 ([#1446](#1446)) ([9e35111](9e35111)) * **deps:** update module golang.org/x/net to v0.32.0 ([#1458](#1458)) ([ac0b123](ac0b123)) * **deps:** update module golang.org/x/sync to v0.9.0 ([#1445](#1445)) ([8893e94](8893e94)) * **deps:** update module google.golang.org/grpc to v1.68.0 ([#1442](#1442)) ([cd27d09](cd27d09)) * **deps:** update module google.golang.org/grpc to v1.68.1 ([#1456](#1456)) ([0b6e2a1](0b6e2a1)) * **deps:** update module google.golang.org/grpc to v1.69.0 ([#1469](#1469)) ([dd4869f](dd4869f)) * **deps:** update module google.golang.org/protobuf to v1.35.2 ([#1450](#1450)) ([6b9834d](6b9834d)) * **deps:** update module google.golang.org/protobuf to v1.36.0 ([#1474](#1474)) ([6a8a9a9](6a8a9a9)) * **deps:** update opentelemetry-go monorepo ([#1447](#1447)) ([68b5794](68b5794)) ### ✨ New Features * add context-value flag ([#1448](#1448)) ([7ca092e](7ca092e)) </details> <details><summary>flagd-proxy: 0.6.8</summary> ## [0.6.8](flagd-proxy/v0.6.7...flagd-proxy/v0.6.8) (2024-12-17) ### 🐛 Bug Fixes * **deps:** update module buf.build/gen/go/open-feature/flagd/protocolbuffers/go to v1.35.2-20240906125204-0a6a901b42e8.1 ([#1451](#1451)) ([8c6d91d](8c6d91d)) * **deps:** update module buf.build/gen/go/open-feature/flagd/protocolbuffers/go to v1.36.0-20240906125204-0a6a901b42e8.1 ([#1475](#1475)) ([0b11c6c](0b11c6c)) * **deps:** update module github.com/open-feature/flagd/core to v0.10.4 ([#1433](#1433)) ([d33c7a5](d33c7a5)) * **deps:** update module golang.org/x/net to v0.31.0 ([#1446](#1446)) ([9e35111](9e35111)) * **deps:** update module golang.org/x/net to v0.32.0 ([#1458](#1458)) ([ac0b123](ac0b123)) * **deps:** update module golang.org/x/sync to v0.9.0 ([#1445](#1445)) ([8893e94](8893e94)) * **deps:** update module google.golang.org/grpc to v1.68.0 ([#1442](#1442)) ([cd27d09](cd27d09)) * **deps:** update module google.golang.org/grpc to v1.68.1 ([#1456](#1456)) ([0b6e2a1](0b6e2a1)) * **deps:** update module google.golang.org/grpc to v1.69.0 ([#1469](#1469)) ([dd4869f](dd4869f)) * **deps:** update opentelemetry-go monorepo ([#1447](#1447)) ([68b5794](68b5794)) </details> <details><summary>core: 0.10.5</summary> ## [0.10.5](core/v0.10.4...core/v0.10.5) (2024-12-17) ### 🐛 Bug Fixes * **deps:** update kubernetes packages to v0.31.2 ([#1430](#1430)) ([0df8622](0df8622)) * **deps:** update kubernetes packages to v0.31.3 ([#1454](#1454)) ([f56d7b0](f56d7b0)) * **deps:** update kubernetes packages to v0.31.4 ([#1461](#1461)) ([431fbb4](431fbb4)) * **deps:** update module buf.build/gen/go/open-feature/flagd/protocolbuffers/go to v1.35.2-20240906125204-0a6a901b42e8.1 ([#1451](#1451)) ([8c6d91d](8c6d91d)) * **deps:** update module buf.build/gen/go/open-feature/flagd/protocolbuffers/go to v1.36.0-20240906125204-0a6a901b42e8.1 ([#1475](#1475)) ([0b11c6c](0b11c6c)) * **deps:** update module github.com/diegoholiveira/jsonlogic/v3 to v3.6.0 ([#1460](#1460)) ([dbc1da4](dbc1da4)) * **deps:** update module github.com/diegoholiveira/jsonlogic/v3 to v3.6.1 ([#1473](#1473)) ([a3d899c](a3d899c)) * **deps:** update module github.com/fsnotify/fsnotify to v1.8.0 ([#1438](#1438)) ([949c73b](949c73b)) * **deps:** update module github.com/stretchr/testify to v1.10.0 ([#1455](#1455)) ([8c843df](8c843df)) * **deps:** update module golang.org/x/crypto to v0.29.0 ([#1443](#1443)) ([db96dd5](db96dd5)) * **deps:** update module golang.org/x/crypto to v0.30.0 ([#1457](#1457)) ([dbdaa19](dbdaa19)) * **deps:** update module golang.org/x/crypto to v0.31.0 ([#1463](#1463)) ([b2245d7](b2245d7)) * **deps:** update module golang.org/x/mod to v0.22.0 ([#1444](#1444)) ([ed064e1](ed064e1)) * **deps:** update module google.golang.org/grpc to v1.68.0 ([#1442](#1442)) ([cd27d09](cd27d09)) * **deps:** update module google.golang.org/grpc to v1.68.1 ([#1456](#1456)) ([0b6e2a1](0b6e2a1)) * **deps:** update module google.golang.org/grpc to v1.69.0 ([#1469](#1469)) ([dd4869f](dd4869f)) * **deps:** update opentelemetry-go monorepo ([#1447](#1447)) ([68b5794](68b5794)) ### ✨ New Features * add context-value flag ([#1448](#1448)) ([7ca092e](7ca092e)) * s3 support for the blob sync ([#1449](#1449)) ([a9f7261](a9f7261)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
toddbaert
added a commit
that referenced
this pull request
Dec 31, 2024
## This PR Intent of this PR is to add the docs that were missing from #1449 ### Notes Happy holidays yall. --------- Signed-off-by: Dave Josephsen <dave.josephsen@gmail.com> Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com> Co-authored-by: Todd Baert <todd.baert@dynatrace.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Intent of this pr is to add S3 bucket support to the existing "blob" sync.
Related Issues
fixes #1376
Notes
Marking as a draft for now until I can find my aws creds and live-test it.
Follow-up Tasks
integration testing is yet to be performed
How to test
unit tests provided